Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp16942200ybl; Wed, 1 Jan 2020 17:46:51 -0800 (PST) X-Google-Smtp-Source: APXvYqzfZztpRoAYEiThRCRbl5If+dFmrCLKwkl6fdnw3/q9PE7jaHT6ocp7frCnUCvLgeL2AsDV X-Received: by 2002:a05:6830:596:: with SMTP id c22mr88028312oth.188.1577929611240; Wed, 01 Jan 2020 17:46:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577929611; cv=none; d=google.com; s=arc-20160816; b=09decBT9JuWYioUCSqf1Iy/x5kE1BrtMbP8EBHj/J+yc6eYaHdODyjac6oEtoGjMpw pJ7BMVKWhtLc5kZ+AkZMPQWbGwCg6eCbptXEu4KufeYXyqjOaD2fCANq5H9D2qQfVpDi 4/olW5GJo67u+9kvQoVkHSXeojvMDPpz7ooYdUWwW6cu9BHaT8d6+ILZi1/bOwFAilfa shQ+TYOdmNQFehSkZN5EQUn8aYD1iw/M4usqWTGAgqq6G2FLfgrZNedsDbegaD4Yj9YN ZhnXVLYYpdFlR7x1D6xU6E5000wmHNJAfmm/LfwvbOK8SqSPzFiv7BbIVoE5sP6GelSn 9E0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=6k7SOw82gB8RQiolTy1Bp/m0C1NkGsEZnFCGypLnXOk=; b=QIvbUN2ekYkbVAvROXUfB9jvmIh1LHtz6j5aE+Rq9n6Z6XHLEGWL5PGB90usmWD4On 1wT7keqxP6jGIeldz8xjYvS25Faf7h0cmyakDlBrY79jKTMjGg1AfnYHBhGX0tgbh4+v LiBBJo8AriRy9TUVp598YGzp6O73pecF2H4AEnckWbcKqFMCQidcHDTB+Wx1krwrZuDL WznJJGhg/AdDYURyHeVuSIYfMmQvirk0HL609S+qx7klgkXtRM+JNS3BHXzvOib1ZFh1 elRU2Qmt2GKskAavlChWhWbSN0s0MPYrhCV2lae7bvkGNxfGBq5Ix+n650UZuGJwhY1J HRvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m5si26249801ote.187.2020.01.01.17.46.37; Wed, 01 Jan 2020 17:46:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbgABBog convert rfc822-to-8bit (ORCPT + 99 others); Wed, 1 Jan 2020 20:44:36 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:39033 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbgABBog (ORCPT ); Wed, 1 Jan 2020 20:44:36 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R641e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04427;MF=teawaterz@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0TmWlbqJ_1577929467; Received: from 127.0.0.1(mailfrom:teawaterz@linux.alibaba.com fp:SMTPD_---0TmWlbqJ_1577929467) by smtp.aliyun-inc.com(127.0.0.1); Thu, 02 Jan 2020 09:44:32 +0800 Content-Type: text/plain; charset=gb2312 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [RFC] memcg: Add swappiness to cgroup2 From: teawater In-Reply-To: <20191231151621.8f1565ef8736233dbf60bca7@linux-foundation.org> Date: Thu, 2 Jan 2020 09:44:25 +0800 Cc: Hui Zhu , hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1577252208-32419-1-git-send-email-teawater@gmail.com> <20191231151621.8f1565ef8736233dbf60bca7@linux-foundation.org> To: Andrew Morton X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > ?? 2020??1??1?գ?07:16??Andrew Morton д???? > > On Wed, 25 Dec 2019 13:36:48 +0800 Hui Zhu wrote: > >> Even if cgroup2 has swap.max, swappiness is still a very useful config. >> This commit add swappiness to cgroup2. >> >> ... >> >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -7143,6 +7143,11 @@ static struct cftype swap_files[] = { >> .file_offset = offsetof(struct mem_cgroup, swap_events_file), >> .seq_show = swap_events_show, >> }, >> + { >> + .name = "swappiness", >> + .read_u64 = mem_cgroup_swappiness_read, >> + .write_u64 = mem_cgroup_swappiness_write, >> + }, >> { } /* terminate */ >> }; > > There should be a Documentation/ update with this? > Hi Andrew, I will post a new version with Documentation/ update. Thanks, Hui > >