Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     =?utf-8?Q?'Pali_Roh=C3=A1r'?= <pali.rohar@gmail.com>
Cc:     <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
        <hch@lst.de>, <sj1557.seo@samsung.com>, <linkinjeon@gmail.com>
In-Reply-To: <20191229134025.qb3mmqatsn5c4gao@pali>
Subject: RE: [PATCH v8 02/13] exfat: add super block operations
Date:   Thu, 2 Jan 2020 15:06:16 +0900
Message-ID: <000701d5c132$bed73c80$3c85b580$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQHsN8nXp7WTsPLA/dnVZpcSktwQNAEpoQLVAH0AW2oCon8f8qeHqjkw
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20191220062419.23516-1-namjae.jeon@samsung.com>
        <CGME20191220062733epcas1p31665a3ae968ab8c70d91a3cddf529e73@epcas1p3.samsung.com>
        <20191220062419.23516-3-namjae.jeon@samsung.com>
        <20191229134025.qb3mmqatsn5c4gao@pali>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > +static const struct fs_parameter_spec exfat_param_specs[] = {
> > +	fsparam_u32("uid",			Opt_uid),
> > +	fsparam_u32("gid",			Opt_gid),
> > +	fsparam_u32oct("umask",			Opt_umask),
> > +	fsparam_u32oct("dmask",			Opt_dmask),
> > +	fsparam_u32oct("fmask",			Opt_fmask),
> > +	fsparam_u32oct("allow_utime",		Opt_allow_utime),
> > +	fsparam_string("iocharset",		Opt_charset),
> > +	fsparam_flag("utf8",			Opt_utf8),
> 
> Hello! What is the purpose of having extra special "utf8" mount option?
> Is not one "iocharset=utf8" option enough?
utf8 nls_table supports utf8<->utf32 conversion and does not support
surrogate character conversion. The utf8 option can support the surrogate
character conversion of utf16 using utf16s_to_utf8s/utf8s_to_utf16s of
the nls base.

Thanks!