Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     Ma Feng <mafeng.ma@huawei.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/i915: use true,false for bool variable in i915_debugfs.c
In-Reply-To: <1577175170-93230-1-git-send-email-mafeng.ma@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <1577175170-93230-1-git-send-email-mafeng.ma@huawei.com>
Date:   Thu, 02 Jan 2020 09:56:44 +0200
Message-ID: <87k16auw8z.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 24 Dec 2019, Ma Feng <mafeng.ma@huawei.com> wrote:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/i915/i915_debugfs.c:3078:4-36: WARNING: Assignment of 0/1 to bool variable
> drivers/gpu/drm/i915/i915_debugfs.c:3078:4-36: WARNING: Assignment of 0/1 to bool variable
> drivers/gpu/drm/i915/i915_debugfs.c:3080:4-36: WARNING: Assignment of 0/1 to bool variable
> drivers/gpu/drm/i915/i915_debugfs.c:3080:4-36: WARNING: Assignment of 0/1 to bool variable
>

Thanks for the patches, but please resend either as a proper threaded
series or unthreaded single patches. Patchwork did not recognize this,
and failed to queue tests.

Sorry for the inconvenience.

BR,
Jani.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index d28468e..4ead86a 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -3075,9 +3075,9 @@ static ssize_t i915_displayport_test_active_write(struct file *file,
>  			 * testing code, only accept an actual value of 1 here
>  			 */
>  			if (val == 1)
> -				intel_dp->compliance.test_active = 1;
> +				intel_dp->compliance.test_active = true;
>  			else
> -				intel_dp->compliance.test_active = 0;
> +				intel_dp->compliance.test_active = false;
>  		}
>  	}
>  	drm_connector_list_iter_end(&conn_iter);
> --
> 2.6.2
>

-- 
Jani Nikula, Intel Open Source Graphics Center