Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932258AbWAZEMu (ORCPT ); Wed, 25 Jan 2006 23:12:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932260AbWAZEMu (ORCPT ); Wed, 25 Jan 2006 23:12:50 -0500 Received: from ozlabs.org ([203.10.76.45]:17364 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S932258AbWAZEMs (ORCPT ); Wed, 25 Jan 2006 23:12:48 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17368.19509.43692.401946@cargo.ozlabs.ibm.com> Date: Thu, 26 Jan 2006 15:12:37 +1100 From: Paul Mackerras To: mita@miraclelinux.com (Akinobu Mita) Cc: "Chen, Kenneth W" , linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, ultralinux@vger.kernel.org, Linux Kernel Development , Andi Kleen , Linux/PPC Development , "'Geert Uytterhoeven'" , sparclinux@vger.kernel.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, parisc-linux@parisc-linux.org Subject: Re: [PATCH 5/6] fix warning on test_ti_thread_flag() In-Reply-To: <20060126035004.GA11543@miraclelinux.com> References: <200601252002.k0PK2Mg31276@unix-os.sc.intel.com> <20060126035004.GA11543@miraclelinux.com> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 21 Akinobu Mita writes: > I can fix this without changing the flags size for those architectures. > > 1. Introduce *_le_bit() bit operations which takes void *addr > (already I have these functions in the scope of > HAVE_ARCH_EXT2_NON_ATOMIC_BITOPS in my patch) > > 2. Change flags to __u8 flags[4] or __u8 flags[8] for each architectures. > > 3. Use *_le_bit() in include/linux/thread_info.h Please don't do this, you'll break the powerpc assembly code that tests bits in thread_info()->flags. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/