Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Jassi Brar <jassisinghbrar@gmail.com>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Devicetree List <devicetree@vger.kernel.org>,
        linux-usb@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCHv1 2/2] usb: gadget: add udc driver for max3420
In-Reply-To: <CABb+yY00xOZw2uw6oK3N6RBcOurJjhiPXHs0ShCSVauwZn6TNw@mail.gmail.com>
References: <20191210003135.32427-1-jassisinghbrar@gmail.com> <87eexclkj0.fsf@gmail.com> <CABb+yY00xOZw2uw6oK3N6RBcOurJjhiPXHs0ShCSVauwZn6TNw@mail.gmail.com>
Date:   Thu, 02 Jan 2020 13:31:22 +0200
Message-ID: <874kxeksc5.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Jassi Brar <jassisinghbrar@gmail.com> writes:
>> > +static void __max3420_start(struct max3420_udc *udc)
>> > +{
>> > +     u8 val;
>> > +
>> > +     /* Need this delay if bus-powered */
>> > +     msleep_interruptible(250);
>>
>> should you check if you're bus powered?
>>
> for some reason, even for self-powered, it helped reliability.

Perhaps update the comment, in that case? It would be better if we had
a proper explanation for this sleep here.

>> > +static int max3420_thread(void *dev_id)
>>
>> Why do you need this thread? Sure you can't live without it?
>>
> All the slow spi-bus transfers are handled at one place here without
> blocking any api call. IMO it is cleaner and easier to manage.

Fair enough, I won't complain. But it looks odd :-p

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl4N1IoACgkQzL64meEa
mQYumA//SLi6nGyho7AKjNXUijFlpjaeLmciwptf1cywEjRc8vdVq699u6H+Z+yr
bQq3iGahlsfYszmsGWsGUYauJyY3+gxBVJb7xmPMpzrzmM3bchdNGLyIJBDfoKoX
OJSMSbll3C5cKEM+hImwnp4ikEoKp4yGdHaPKxH0RKfHMLfIWaOf5Q1NeTOnF1K7
6Rw+8S97fVMwy8zL/roatNlC3Y6dSYjD4ahU3WVXL5CrC9IYhpIYomZ7+MzQ0iWN
tDsT+QsLpBEIJaMMT9WCfnymCAKbvTvRq2S07SSbZMXx6g8TQtkGhA8E8zglt7hZ
0tsCHi2kLBmKTKzOZ+/VEFFQaAuMFC6G3nMl70Pf5LIiYTQTUu3BBO1E1YwIGNOr
ukWKCmBC48/wig/C/juMKotiP8gg8V1OX9rnHQjsHXq4jfj2DCu9bOBD3a5/bokn
uwtC+ULssM4B7JqASQXygzsM1eN9daLGIqKdI10lnruPW2YuSXqEoYFQx0tDiZdD
bqEmo+9UMBNVzH7ehawJ90FixIgrnxsFbd6vwuNGqUF09UDKzKRkEIljah2gkyK4
Xfpo53Q4Y1QEAayrtycA05Wpilwf3sTAVg6cu0LvMsbbDcCw7kPMhjEC9HJA2Z2T
HY3SbjksbpEqiqH3k4bVnall6ltCYdBOlFqXx70Aao0CCZhDP1E=
=sA7L
-----END PGP SIGNATURE-----
--=-=-=--