Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20200102083029.uv2gtig3ski23dpe@pali>
References: <20191220062419.23516-1-namjae.jeon@samsung.com>
 <CGME20191220062733epcas1p31665a3ae968ab8c70d91a3cddf529e73@epcas1p3.samsung.com>
 <20191220062419.23516-3-namjae.jeon@samsung.com> <20191229134025.qb3mmqatsn5c4gao@pali>
 <000701d5c132$bed73c80$3c85b580$@samsung.com> <20200102083029.uv2gtig3ski23dpe@pali>
From:   Namjae Jeon <linkinjeon@gmail.com>
Date:   Thu, 2 Jan 2020 22:13:50 +0900
Message-ID: <CAKYAXd-CUyC9vTLH7ANumLxrAQCmb8Xi=2v4-uotLFBuxf_+Cw@mail.gmail.com>
Subject: Re: [PATCH v8 02/13] exfat: add super block operations
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020-01-02 17:30 GMT+09:00, Pali Roh=C3=A1r <pali.rohar@gmail.com>:
> On Thursday 02 January 2020 15:06:16 Namjae Jeon wrote:
>> > > +static const struct fs_parameter_spec exfat_param_specs[] =3D {
>> > > +	fsparam_u32("uid",			Opt_uid),
>> > > +	fsparam_u32("gid",			Opt_gid),
>> > > +	fsparam_u32oct("umask",			Opt_umask),
>> > > +	fsparam_u32oct("dmask",			Opt_dmask),
>> > > +	fsparam_u32oct("fmask",			Opt_fmask),
>> > > +	fsparam_u32oct("allow_utime",		Opt_allow_utime),
>> > > +	fsparam_string("iocharset",		Opt_charset),
>> > > +	fsparam_flag("utf8",			Opt_utf8),
>> >
>> > Hello! What is the purpose of having extra special "utf8" mount option=
?
>> > Is not one "iocharset=3Dutf8" option enough?
>> utf8 nls_table supports utf8<->utf32 conversion and does not support
>> surrogate character conversion.
>
> So in other words, this is just subset of UTF-8 just to 3 byte long
> sequences (for Unicode code points up to the U+FFFF).
>
>> The utf8 option can support the surrogate
>> character conversion of utf16 using utf16s_to_utf8s/utf8s_to_utf16s of
>> the nls base.
>
> So this is full UTF-8 support, right?
>
> And what is the point to have two options for UTF-8 support, when one is
> incomplete / broken? I see no benefit to have first option at all.
> Providing incomplete / broken support to userspace does not make much
> sense if we already have full and working support via different mount
> option. Maybe second option with full UTF-8 support should be used also
> by iocharset=3Dutf8 and then we do not need utf8 option at all?
Make sense. I will make it one option.

Thanks!
>
> --
> Pali Roh=C3=A1r
> pali.rohar@gmail.com
>