Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp17514429ybl; Thu, 2 Jan 2020 06:55:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwJNsBR+Gkv5EvBTPfOr6V8iZVnWGXnhL+MjYJ03FVszmQZ7h51cBjxs1rmJwGNSgMBOhtF X-Received: by 2002:a05:6830:2102:: with SMTP id i2mr90188843otc.123.1577976951984; Thu, 02 Jan 2020 06:55:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577976951; cv=none; d=google.com; s=arc-20160816; b=wpqfJ7Lu9J3QkGshFMGvxzLKf/tyRq+9CJVqeuJk/7bEmPNSPcwODrNg7MdkmGWzah TEfrbhDif84sNGxR4eat7QjYvsZsP7XqxX7jkWTYAceeSF5m8dLfmsLxgCTJQc5Hfrjz S3AnpYtU+T2cFKwx+T72N03LNagfmtpo6s1HTYGCqR8Dk2IJt02P6+J51ODrIMnlB7ps ege9bDaEkSoQ6BUUeMJGX/FzzCs3Q0BWkEaokNGNGwNG2OwAoELeKjjzriUWwq8eU42U K7TJT08fd0aEn7joo7cef5o86NEvw59hXf/OooL1nuskkpnC0VtyMjcYxJdCTB2JxEcU nVjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fBoLG1yNGX8O84D+YcSt5B+i5/exbpkdJTkAsAGAlGk=; b=cxgH7kLT3TOlWw6E8FoqUFgzG9w+5foRG0lAOmci4wtHjXtamijZOW7N9B32EmbjZP Z8tVhrLdPFP+AgTBq6SayUnwmCXi2vKZ5EAOs93nVxVooNYpn0dKL2ba2XbH65TbjzAB 2RwUSYVYZdQEp70bPm5RfNyjxtr/PWoovijaJljb1JTFtfJHt2lMq5957ME0cbmzXeA2 dvaQpbcMNYlvcfoKEPhzgVQCDPlb/Ztq0Yvj3Z1IsnC0ozWegViv4YsSYI7QtQSLZVuQ 1mOmDAN6/mFpO4op5za1ptvDboozaHzOb2VS5PoVx527gx6vUH/ypP9eeC/51sqUD91L N76g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qCXuNdiS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l26si27434269oti.152.2020.01.02.06.55.40; Thu, 02 Jan 2020 06:55:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qCXuNdiS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728621AbgABOy4 (ORCPT + 99 others); Thu, 2 Jan 2020 09:54:56 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:40372 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728616AbgABOyz (ORCPT ); Thu, 2 Jan 2020 09:54:55 -0500 Received: by mail-pj1-f66.google.com with SMTP id bg7so3437696pjb.5 for ; Thu, 02 Jan 2020 06:54:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fBoLG1yNGX8O84D+YcSt5B+i5/exbpkdJTkAsAGAlGk=; b=qCXuNdiSR16NjCl2MfuL4UuKLIGqC+aI6fJyLyPkOWfXERE1srFvi+G65shbWPvUUB yak7t+K9YILtB2M5FMNMR0YVzag6Juq+ocVuPWl4xIQl5Eg6pHAvopOBMrsQm2p6dinN 4vqGMMaqasKh/O+sWbMJj6uYO5QmuxYeiWAjg+56ly2wJAU/THpVF1vGf/phd7stDSx8 oor7SODucz0k2ufCAhJSTm4r8ryWa8AEXXGZcImfJq3LhB6ZQRv4sGTStymGBlnryzLe 5PEr+I6wFkGsD+I8Oi1wwF49AmSc9yM5qb+3h28Jt2WDCaESn9e2horyLYCaeeEVC9dF gYRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fBoLG1yNGX8O84D+YcSt5B+i5/exbpkdJTkAsAGAlGk=; b=pBgyAr3gOHOf8pCVl+ZNe6fFhA49wAaE+LYepemNAQpKeqjjQWrEr/hwTtedfyLiy4 nuDwIb1Yj+KIludPT/SOhHavSNtPEYGeDj5OJSJQemVvx2SQSY4Cmc/CHTEd0OMQWiEX SkaM1pFiO+FbHBI1X0cW1sZqRhRKBEC0iJtsVrhJmAAl6m+uxTHu+w5WnOL4u00IVZXd ILz3A50/ePuV6Le4KU0gR0TvzGcPw0A++mQ/CIUW4mpS/0gZhMMncgLpjh0OSB/P4izR k4jRwPP1E5x07zD/3C8fcmYxPeqsBaXIwGKzMKM51A9Xxdo4ENMpOPQmqoCBwNWjcXtr Z+vw== X-Gm-Message-State: APjAAAVq0jiYD10+WoHZd/UdDi6yOKRet3aEWXoPppmwMDPrxJlYTOt7 Ty1gWFTRecv/fbwAyTCMONqn7nhsijVeEA== X-Received: by 2002:a17:90a:26ec:: with SMTP id m99mr20400488pje.130.1577976894354; Thu, 02 Jan 2020 06:54:54 -0800 (PST) Received: from localhost ([103.195.202.148]) by smtp.gmail.com with ESMTPSA id h128sm66808306pfe.172.2020.01.02.06.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 06:54:53 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, swboyd@chromium.org, sivaa@codeaurora.org, Andy Gross Cc: Amit Kucheria , linux-pm@vger.kernel.org Subject: [PATCH v3 4/9] drivers: thermal: tsens: Release device in success path Date: Thu, 2 Jan 2020 20:24:29 +0530 Message-Id: <0a969ecd48910dac4da81581eff45b5e579b2bfc.1577976221.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't currently call put_device in case of successfully initialising the device. Allow control to fall through so we can use same code for success and error paths to put_device. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index 1cbc5a6e5b4f..e84e94a6f1a7 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -687,8 +687,6 @@ int __init init_common(struct tsens_priv *priv) tsens_enable_irq(priv); tsens_debug_init(op); - return 0; - err_put_device: put_device(&op->dev); return ret; -- 2.20.1