Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Saleem, Shiraz" <shiraz.saleem@intel.com>
To:     Xiyu Yang <xiyuyang19@fudan.edu.cn>
CC:     "yuanxzhang@fudan.edu.cn" <yuanxzhang@fudan.edu.cn>,
        "kjlu@umn.edu" <kjlu@umn.edu>, "leon@kernel.org" <leon@kernel.org>,
        "Markus.Elfring@web.de" <Markus.Elfring@web.de>,
        Xin Tan <tanxin.ctf@gmail.com>,
        "Latif, Faisal" <faisal.latif@intel.com>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Shannon Nelson <shannon.nelson@intel.com>,
        "Singhai, Anjali" <anjali.singhai@intel.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4] infiniband: i40iw: fix a potential NULL pointer
 dereference
Thread-Topic: [PATCH v4] infiniband: i40iw: fix a potential NULL pointer
 dereference
Thread-Index: AQHVvrhzchRnSKHHyEuZXScGHS/Gk6fXj3Rw
Date:   Thu, 2 Jan 2020 16:09:38 +0000
Message-ID: <9DD61F30A802C4429A01CA4200E302A7C1DEF336@fmsmsx123.amr.corp.intel.com>
References: <1577672668-46499-1-git-send-email-xiyuyang19@fudan.edu.cn>
In-Reply-To: <1577672668-46499-1-git-send-email-xiyuyang19@fudan.edu.cn>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Subject: [PATCH v4] infiniband: i40iw: fix a potential NULL pointer dereference
> 
> A NULL pointer can be returned by in_dev_get(). Thus add a corresponding check
> so that a NULL pointer dereference will be avoided at this place.
> 
> Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status")
> Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> Changes in v2:
> - Release rtnl lock when in_dev_get return NULL Changes in v3:
> - Continue the next loop when in_dev_get return NULL Changes in v4:
> - Change commit message
> 

Thanks! Looks ok.

I believe Leon caught another issue in how rtnl locking scheme is done in this function.
Will fix.

Shiraz