Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 Jan 2020 12:07:52 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Qian Cai <cai@lca.pw>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>, tytso@mit.edu,
        Arnd Bergmann <arnd@arndb.de>, gregkh@linuxfoundation.org,
        pmladek@suse.com, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, dan.j.williams@intel.com,
        Peter Zijlstra <peterz@infradead.org>, longman@redhat.com,
        Thomas Gleixner <tglx@linutronix.de>,
        Linux-MM <linux-mm@kvack.org>,
        linux-arm-kernel@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] char/random: silence a lockdep splat with printk()
Message-ID: <20200102120752.7b893b1e@gandalf.local.home>
In-Reply-To: <1CA39814-DE67-4112-8F97-D62B9F47FF9D@lca.pw>
References: <20191205010055.GO93017@google.com>
        <4F9E9335-334B-4600-8BC3-4AF91510D113@lca.pw>
        <1CA39814-DE67-4112-8F97-D62B9F47FF9D@lca.pw>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2 Jan 2020 10:42:51 -0500
Qian Cai <cai@lca.pw> wrote:

> > On Dec 16, 2019, at 8:52 PM, Qian Cai <cai@lca.pw> wrote:
> > 
> > 
> >   
> >> On Dec 4, 2019, at 8:00 PM, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
> >> 
> >> A 'Reviewed-by' will suffice.
> >> 
> >> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>  
> > 
> > Ted, could you take a look at this trivial patch?  
> 
> Not sure if Ted is still interested in maintaining this file as he had no feedback for more
> than a month. The problem is that this will render the lockdep useless for a general
> debugging tool as it will disable the lockdep early in the process.
> 

How would this disable lockdep early in the process? The patch is just
changing pr_notice() to printk_deferred() correct?

-- Steve