Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp17775893ybl; Thu, 2 Jan 2020 11:48:56 -0800 (PST) X-Google-Smtp-Source: APXvYqxbCEaW+6TE8LZet2IEd7hzdScDwaXtjXEhOg6MPjQ4rppuRixR1grjrKfpKZsmjifZ6/0V X-Received: by 2002:a9d:53cb:: with SMTP id i11mr96216627oth.158.1577994536246; Thu, 02 Jan 2020 11:48:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577994536; cv=none; d=google.com; s=arc-20160816; b=bbgMB1uRy/qncXTv+eRno0PML719E3pXd7H2BpMpxMUUu/9/aZtjCv8+FKkZ/sVKfc yuAfx/46hdsh0x1YwWLDV6PaSbjwE71ueFfPs8acyvtzYDKRAPu+bAR4n0DgaSZtYhv1 U0zzxYTJg1m1gWkQcIC1NldUePQMhZD28ifUS+oraNP0jfpVFCpDV6TQxt20k8OnEF0u nfpCOfNXyQBEME24O+j8JkVlBx66sf9CjWwX3RcbGlcVRPncKFc1MuLyWOuyM/3E4tpB sYAVrnN4EKxnnw5FOOVBzClFiHA9Ykvizr0w+N+FTxhmjSSDhjqQHZIntCQHg5T+FSl+ /nTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BinIw4199yqCG0c+gGZlznPchIyL9Pm9n06/Ts9kq1o=; b=dGDmr25Hd8GyZdHgMqFS5jkV/M5UC2KuEY1pID+XljLxMhNONLEcVv4XlYiTSbJd8y 3VQxFAFSG6k6wK1wKWLOtU3qF05rrJQvHhBgaIbK+8FPtnZZRyigDp5S7D91d50kmvUn f33qZ0T+cSEuezJ5lhnuZmMy4rPuqsagLsycJEIS/sBtZHtwPMeFgYq2heGIMsZfdiI2 i2MeQ9c107YQE9+dRFoCIAmXSWH4DgnKAaJuhVDXK3YX4KifNiIE3O4UsbPTTXH2FONH U/Ga3PSJkvH129df2Njl9NGb6B5b/lr0X+ZZxNwI94v+f2J2InjyZgBhNW+IgxpW4IpY yv0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=UVRbxZ+E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8si27838121ota.266.2020.01.02.11.48.43; Thu, 02 Jan 2020 11:48:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=UVRbxZ+E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728479AbgABTqi (ORCPT + 99 others); Thu, 2 Jan 2020 14:46:38 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41268 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727951AbgABTqi (ORCPT ); Thu, 2 Jan 2020 14:46:38 -0500 Received: by mail-pg1-f196.google.com with SMTP id x8so22362207pgk.8 for ; Thu, 02 Jan 2020 11:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BinIw4199yqCG0c+gGZlznPchIyL9Pm9n06/Ts9kq1o=; b=UVRbxZ+ESJObjtXUeIGy+0c187HOKQbgX4ZvWmu2f6wOILEz9jrB7ZMKjT8qdHfQcS CurWFzw0VznwhtOyUq1JppbsAMiENxxJ+EHu1O+hTb63M6NYzOyMqmZ6DdPuVbZBVkSg eBMZ/FSQjGIdwaBxeYKAyYI6Or+8w4ny3Qs40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BinIw4199yqCG0c+gGZlznPchIyL9Pm9n06/Ts9kq1o=; b=rnX7Cteyj5GtRmuxSQFylS9POoTmOEpcqaFIvOKDJO5bLy9KTirld52HSxaYHQKfiZ SEWy733r9r4K+JrEZGb8ZH4fDeYzIFLGK/6YhOcIYxtBfzHnLL7M6TYJZNsQG7jd2waE c6LmwZ3i8RJZShGjOiiT5v1NFRrP5uxp85T2bdHqA0+T+IcznZDctYXjHR6n5KnGbYhU W6FKRARgmSgKe668w6FbAa3yT3xKYSc/e1zc2WRZyk49TNO11u6Rd2Lc43d4gjaF2DGc LcTG2q263YXhleotNSsZ0PKMxFIJSLGPTuLAre5MbB+vu5jVPBuG4Lfu6+LWL+iPgsaY i5mQ== X-Gm-Message-State: APjAAAWPvuZOA8rUq8BLz/NKAuvovPTA+K6VxQXNo3ueAjfIdPlEFE+P 9q7P02ujtS2uq7NDlPMek3UeWbAA4js= X-Received: by 2002:a63:496:: with SMTP id 144mr94420117pge.207.1577994397373; Thu, 02 Jan 2020 11:46:37 -0800 (PST) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id 18sm57602040pfj.3.2020.01.02.11.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 11:46:36 -0800 (PST) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Antonio Borneo , Bjorn Helgaas , David Sterba , Ingo Molnar , Mike Rapoport , "Rafael J. Wysocki" , Sakari Ailus , Steven Rostedt Subject: [PATCH] tracing: Change offset type to s32 in preempt/irq tracepoints Date: Thu, 2 Jan 2020 14:46:25 -0500 Message-Id: <20200102194625.226436-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.24.1.735.g03f4e72817-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Discussion in the below link reported that symbols in modules can appear to be before _stext on ARM architecture, causing wrapping with the offsets of this tracepoint. Change the offset type to s32 to fix this. Link: http://lore.kernel.org/r/20191127154428.191095-1-antonio.borneo@st.com Signed-off-by: Joel Fernandes (Google) Cc: Antonio Borneo --- include/trace/events/preemptirq.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/trace/events/preemptirq.h b/include/trace/events/preemptirq.h index 95fba0471e5b..3f249e150c0c 100644 --- a/include/trace/events/preemptirq.h +++ b/include/trace/events/preemptirq.h @@ -18,13 +18,13 @@ DECLARE_EVENT_CLASS(preemptirq_template, TP_ARGS(ip, parent_ip), TP_STRUCT__entry( - __field(u32, caller_offs) - __field(u32, parent_offs) + __field(s32, caller_offs) + __field(s32, parent_offs) ), TP_fast_assign( - __entry->caller_offs = (u32)(ip - (unsigned long)_stext); - __entry->parent_offs = (u32)(parent_ip - (unsigned long)_stext); + __entry->caller_offs = (s32)(ip - (unsigned long)_stext); + __entry->parent_offs = (s32)(parent_ip - (unsigned long)_stext); ), TP_printk("caller=%pS parent=%pS", -- 2.24.1.735.g03f4e72817-goog