Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp17893614ybl; Thu, 2 Jan 2020 14:14:52 -0800 (PST) X-Google-Smtp-Source: APXvYqxxFgdA8jAPBrqWG3+bSqKVdrAlDfWTLSFxwLRcNTt6dfVc94FE0rEEneIYdFrHz5c625KP X-Received: by 2002:a9d:74c4:: with SMTP id a4mr9176739otl.119.1578003292409; Thu, 02 Jan 2020 14:14:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578003292; cv=none; d=google.com; s=arc-20160816; b=x/VJKpuzX8EcVuNqUQ+g2xf8hoPoQ0LBhpaJ1aWqLS582kY3n+WaoUTHRNAgdM5es9 WcOu6lO0V58eiVzOzRi/0spWUMm8jRk7glpx3zFHTzWZim+Gqd1a5UhbZA5bmuxYDEf0 E6f8FQycdkm1Ny7T7ZNUrrC+Aeou0nQo1QuJufgKM6pCqj9m/0/tS9aTDGuLdpJpoXOR Fsnj9fqDRBnMoKHlTbYnNi4n/HA+U+t9OWxKoEtROL1eiwAAUH38u5m31QJbU1EEn68S ng+jS122/4XqlNqr0miKPL+irbc6yvINUTt1tsdrityg6BrYQGV0hDJonWy1ixhaVjXb FbDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vlE46CdwWHk43QGV/02O5ZErpxXmmaXT7Bsav8W78ZM=; b=BsEiJ0fLKSxEJlVaFDCodS+RfJXiefj8L+yGRgQEdie83H0Qq5co5egFJR48SHhZ7o mt/81dVw09HqNpxg5OLtwofaJi2Z+hawpR4TMhLRUJhuDk/Zo+b2H0r0WtdKyKiRkP9w RbxRLsTzSJuz9djijIl8tpeE/M2WQ7CRVb++zifnaREQVY0UReQ1/Dw/uz6hGJI/ExiN 4C5IdHhDcxqNb0RimSgmgucBx1Cgj7NWkPOlf/bxU7ZKLoXKces4V39E7hE+FpqqNaUM rl5bNRpwMPbX35/ILND9kJvVTGc7gVJok8Lxx1z4+ThWAOslMn4/jkd8XFc6QittBsgB wHcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EnqsdYLI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y24si25452508oih.24.2020.01.02.14.14.40; Thu, 02 Jan 2020 14:14:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EnqsdYLI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727708AbgABWNd (ORCPT + 99 others); Thu, 2 Jan 2020 17:13:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:53268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727700AbgABWN2 (ORCPT ); Thu, 2 Jan 2020 17:13:28 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03E8122314; Thu, 2 Jan 2020 22:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578003208; bh=vHYiEBm4hwCcFW+UIiBtvdtdp4O3/P1BrzrnoP0+PRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EnqsdYLIMeh3EORTKPAnO0DQyXIuMhXVumuSsu8phTX53UZmxqvQZgqsONjMlF+wc 8JIEwb6wKomQ8bn72AEMTWcc5Z64cRJE1pGOWDQVRVeQjUrEtV29MI0Im/+qr++Oww nu2VrDHAS4jXEWE7F8MiTiy0YgYuC4fiGwmtNwCg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Corentin Labbe , Christoph Hellwig , Marek Szyprowski , Sasha Levin Subject: [PATCH 5.4 029/191] dma-debug: add a schedule point in debug_dma_dump_mappings() Date: Thu, 2 Jan 2020 23:05:11 +0100 Message-Id: <20200102215833.093514241@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102215829.911231638@linuxfoundation.org> References: <20200102215829.911231638@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit 9ff6aa027dbb98755f0265695354f2dd07c0d1ce ] debug_dma_dump_mappings() can take a lot of cpu cycles : lpk43:/# time wc -l /sys/kernel/debug/dma-api/dump 163435 /sys/kernel/debug/dma-api/dump real 0m0.463s user 0m0.003s sys 0m0.459s Let's add a cond_resched() to avoid holding cpu for too long. Signed-off-by: Eric Dumazet Cc: Corentin Labbe Cc: Christoph Hellwig Cc: Marek Szyprowski Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- kernel/dma/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c index 099002d84f46..4ad74f5987ea 100644 --- a/kernel/dma/debug.c +++ b/kernel/dma/debug.c @@ -420,6 +420,7 @@ void debug_dma_dump_mappings(struct device *dev) } spin_unlock_irqrestore(&bucket->lock, flags); + cond_resched(); } } -- 2.20.1