Received: by 2002:a17:90a:9103:0:0:0:0 with SMTP id k3csp11792784pjo; Thu, 2 Jan 2020 14:22:15 -0800 (PST) X-Google-Smtp-Source: APXvYqzoN0Z+XCIFTEzMWKeMkrMRo5skyfWUOnOvtDhWlGvUODqay5eRtawUTaLt5BvRLWz7aIPI X-Received: by 2002:a05:6808:291:: with SMTP id z17mr3041188oic.94.1578003734983; Thu, 02 Jan 2020 14:22:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578003734; cv=none; d=google.com; s=arc-20160816; b=hT45lIA9XDl1zKUzh3mZwXBgqsio+dE/30dMipIt6LQg+govrPN+ojbNKb+7eSNwyy hVJiP/zu0jIcscpH24UJUI1qyLbnxOsHEz4y5Wu3+zdBSl//29h8NVkLiQDv7LOoPPGL oxJZVk8NewNwfMX6JHNKAr7QZ8u9oAhZ13l8/nV8OaIVAL2nis+0ryGGE0Tqlwwty+sr WYD5P7CB9AlqV/q3Ka4g0/vePTNXoyry15mrfiPo4UHGSdnJ2330msjHdA5L5QLcmQjk d8iqRsEenpi7bnGeTMRlir/ng6hWFN5QhsKoJplwLOmXVB8jy3NrBQeySgzzfzf0KImS 3gcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=x8BX71oo3DJhY62ZoIf15dMe7+8FbZykdBEJRjovihg=; b=vGMIrKUyKaQFBEnhwlmob9wfNfIImTWbby+/uO8gplJfVm2B88py5d7JGn7MaVNzYf 8sBMtXfxNmxatN/s0To5jP5WmnB01cmo5cEDxBRO4jgqXIYeiux5s4ycT85Dis+11a85 +mRrLyvqjizkOD3jDAuSKXhcHyIEWwA6zqItkdNJs7P3shN7j3ZevgVkjDB3BnwvAZnI TPDVBwGQCNNnjEmfOoJf8mzUMAAjzqbs7J47ICBxwWMvAFwZk3ARqW+YowUNZAnrCcx4 cjS98h9am/fbGrnHPkpLrsEzj/C2U2UQOcjMZLegOPZe9DK2ZZRdO4OO7VOPUqeeQKUG EkBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0N2nn3m6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o128si26690936oih.66.2020.01.02.14.22.03; Thu, 02 Jan 2020 14:22:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0N2nn3m6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728791AbgABWV0 (ORCPT + 99 others); Thu, 2 Jan 2020 17:21:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:40370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728341AbgABWVX (ORCPT ); Thu, 2 Jan 2020 17:21:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12EFF2253D; Thu, 2 Jan 2020 22:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578003682; bh=dRUxQmiTazbrVsjjmAMxwSYiCkunN4KSxORzQPmk5gY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0N2nn3m6ZAnZ4CY+2vdrZi93JyfXnceiAECTJjwslFugHd+VfKXEMnHZ03aB/1B5k 6BteG1iHPwgM9QrESBOhww8mK2BsjRjshkE3zDljwV5kkSSF//qGm+1Aq7TzmjftJQ Zqk17rAScyqo3donphc4F+sfu00DGTu64ei+nJZM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oleksij Rempel , Daniel Baluta , Richard Zhu , Dong Aisheng , Jassi Brar , Sasha Levin Subject: [PATCH 4.19 070/114] mailbox: imx: Fix Tx doorbell shutdown path Date: Thu, 2 Jan 2020 23:07:22 +0100 Message-Id: <20200102220036.133311996@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220029.183913184@linuxfoundation.org> References: <20200102220029.183913184@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Baluta [ Upstream commit bf159d151a0b844be28882f39e316b5800acaa2b ] Tx doorbell is handled by txdb_tasklet and doesn't have an associated IRQ. Anyhow, imx_mu_shutdown ignores this and tries to free an IRQ that wasn't requested for Tx DB resulting in the following warning: [ 1.967644] Trying to free already-free IRQ 26 [ 1.972108] WARNING: CPU: 2 PID: 157 at kernel/irq/manage.c:1708 __free_irq+0xc0/0x358 [ 1.980024] Modules linked in: [ 1.983088] CPU: 2 PID: 157 Comm: kworker/2:1 Tainted: G [ 1.993524] Hardware name: Freescale i.MX8QXP MEK (DT) [ 1.998668] Workqueue: events deferred_probe_work_func [ 2.003812] pstate: 60000085 (nZCv daIf -PAN -UAO) [ 2.008607] pc : __free_irq+0xc0/0x358 [ 2.012364] lr : __free_irq+0xc0/0x358 [ 2.016111] sp : ffff00001179b7e0 [ 2.019422] x29: ffff00001179b7e0 x28: 0000000000000018 [ 2.024736] x27: ffff000011233000 x26: 0000000000000004 [ 2.030053] x25: 000000000000001a x24: ffff80083bec74d4 [ 2.035369] x23: 0000000000000000 x22: ffff80083bec7588 [ 2.040686] x21: ffff80083b1fe8d8 x20: ffff80083bec7400 [ 2.046003] x19: 0000000000000000 x18: ffffffffffffffff [ 2.051320] x17: 0000000000000000 x16: 0000000000000000 [ 2.056637] x15: ffff0000111296c8 x14: ffff00009179b517 [ 2.061953] x13: ffff00001179b525 x12: ffff000011142000 [ 2.067270] x11: ffff000011129f20 x10: ffff0000105da970 [ 2.072587] x9 : 00000000ffffffd0 x8 : 0000000000000194 [ 2.077903] x7 : 612065657266206f x6 : ffff0000111e7b09 [ 2.083220] x5 : 0000000000000003 x4 : 0000000000000000 [ 2.088537] x3 : 0000000000000000 x2 : 00000000ffffffff [ 2.093854] x1 : 28b70f0a2b60a500 x0 : 0000000000000000 [ 2.099173] Call trace: [ 2.101618] __free_irq+0xc0/0x358 [ 2.105021] free_irq+0x38/0x98 [ 2.108170] imx_mu_shutdown+0x90/0xb0 [ 2.111921] mbox_free_channel.part.2+0x24/0xb8 [ 2.116453] mbox_free_channel+0x18/0x28 This bug is present from the beginning of times. Cc: Oleksij Rempel Signed-off-by: Daniel Baluta Signed-off-by: Richard Zhu Reviewed-by: Dong Aisheng Signed-off-by: Jassi Brar Signed-off-by: Sasha Levin --- drivers/mailbox/imx-mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 363d35d5e49d..2f47023cab2b 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -214,8 +214,10 @@ static void imx_mu_shutdown(struct mbox_chan *chan) struct imx_mu_priv *priv = to_imx_mu_priv(chan->mbox); struct imx_mu_con_priv *cp = chan->con_priv; - if (cp->type == IMX_MU_TYPE_TXDB) + if (cp->type == IMX_MU_TYPE_TXDB) { tasklet_kill(&cp->txdb_tasklet); + return; + } imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx) | IMX_MU_xCR_RIEn(cp->idx)); -- 2.20.1