Received: by 2002:a17:90a:9103:0:0:0:0 with SMTP id k3csp11801937pjo; Thu, 2 Jan 2020 14:31:55 -0800 (PST) X-Google-Smtp-Source: APXvYqyCdI+FDvlczMPy42F7R8Uo/+Bqnb0leMej5joPWsjo/Z8dCBOIPPjzLLoDvYdyEgXLaI72 X-Received: by 2002:a9d:32f:: with SMTP id 44mr45680958otv.234.1578004315718; Thu, 02 Jan 2020 14:31:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578004315; cv=none; d=google.com; s=arc-20160816; b=JGCJaf8WWjW+M1I9YOO4BoHyizgpzfK/8xClf2xKw8IaQnQX2MRTyC0e7+5u2sT0cj fKQHt5I6XcWl5ffrsKwFGZ1Jl4YGHYlDF21K+byWoRAiMvkV6Al5VKBkCWRDxiOif0Vs TYsV0bhz2lZUYwivZnSyYuEXN4Jxfnlo1C/xSNr+6DzCsf5VoWTJ+LJsJMVtv+wNHcSa qJcK0IKqYVRIM117KOoljjobIYDkdayVig7J9VRaVLIWs2JTsZIGgjAFSZ3Wj/FCnwGH hDTKlYskqHn+Vdw0TG0mPhRxVqyUwlZ5uQAdAxblFU0ufga5Nv1GLWhwwyRapQY1jrEs 73lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v3E6kEy294HN+/KxXPlgbfEhCdfHrbaKOkuTbvk5Zp8=; b=oBS8qKp5H283tmOYBcH3ZNdBjAFiWbgDvQbek1aSnCoCT+SKsxF+RZHDzfIOq8rdi1 dPx6E3OII05WxF7wUsGogPfUjbXvbKWllayoZLEBmQlXUHlISzmZC9VSJbEIpIyMFI8+ HztXXGf8jo4KvQywkGOK/i4jrzPP2xlf6RGgM2ppAJH8oJqeIC1DVRN8/Hi3nZVzXSpe xz6/MWTGAJA70aDjRIoAyMOVaoGTS9Vx+7u7aosZiEMv3EbxHGWDuHpTENXIAIWZdm4I bEp3kFwAv4cWqw1E6BbdyJRGqeV3nVrF+uNNO6TfDxIl19bz84qz2aDRqyHa2m29TRfW +iJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QMT7uf7N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si26457972otm.165.2020.01.02.14.31.42; Thu, 02 Jan 2020 14:31:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QMT7uf7N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730232AbgABWbC (ORCPT + 99 others); Thu, 2 Jan 2020 17:31:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:35450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729966AbgABWa4 (ORCPT ); Thu, 2 Jan 2020 17:30:56 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F89420863; Thu, 2 Jan 2020 22:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004255; bh=lUUJhjEuGA3Oseknaq7GlT9S4DmCuURlVakH+oLWOAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QMT7uf7Nnhpz/Rxq2SWvTmJBy1PMTeCFdS8NYNRxqr2+05seKnUFvZkOR0dQWsWLR vkM2NSMIF+zG5psdjsnaIHzdcrQvwNztCH0f+KjP6WFe31z87UF3oNY+yGPOWgQET/ LU6KuOVXpDHFC142wFRka1Hoy2RCScV21wZMUJOs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Mark Brown , Sasha Levin Subject: [PATCH 4.9 077/171] spi: st-ssc4: add missed pm_runtime_disable Date: Thu, 2 Jan 2020 23:06:48 +0100 Message-Id: <20200102220557.617918001@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.960200039@linuxfoundation.org> References: <20200102220546.960200039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan [ Upstream commit cd050abeba2a95fe5374eec28ad2244617bcbab6 ] The driver forgets to call pm_runtime_disable in probe failure and remove. Add the missed calls to fix it. Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191118024848.21645-1-hslester96@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-st-ssc4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-st-ssc4.c b/drivers/spi/spi-st-ssc4.c index e54b59638458..710adbc2485f 100644 --- a/drivers/spi/spi-st-ssc4.c +++ b/drivers/spi/spi-st-ssc4.c @@ -385,6 +385,7 @@ static int spi_st_probe(struct platform_device *pdev) return 0; clk_disable: + pm_runtime_disable(&pdev->dev); clk_disable_unprepare(spi_st->clk); put_master: spi_master_put(master); @@ -396,6 +397,8 @@ static int spi_st_remove(struct platform_device *pdev) struct spi_master *master = platform_get_drvdata(pdev); struct spi_st *spi_st = spi_master_get_devdata(master); + pm_runtime_disable(&pdev->dev); + clk_disable_unprepare(spi_st->clk); pinctrl_pm_select_sleep_state(&pdev->dev); -- 2.20.1