Received: by 2002:a17:90a:9103:0:0:0:0 with SMTP id k3csp11802151pjo; Thu, 2 Jan 2020 14:32:08 -0800 (PST) X-Google-Smtp-Source: APXvYqz0j76IOzR65efbDw9q08jeG1L7gjoF7O4A+NtuIO7s7aBE0wJb2J+vypk5I9HJYvVbN2l4 X-Received: by 2002:a05:6830:1149:: with SMTP id x9mr96563924otq.156.1578004328607; Thu, 02 Jan 2020 14:32:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578004328; cv=none; d=google.com; s=arc-20160816; b=FxO4Yy8ZXoXurRfXjx/3d1HUvUrDJLUaWu2WvB/Zw6VffbbD94bBBqkQrbBRCcljNT cQaUPaan+9nQYgVHiAAWxWInAFe1STSUJy5QvHOEQdko0BEWghZC5wTcbY+nkUTpNH0x RuT/Xw/ocb7LqbGIO6d4Gm6437m9ns/V/PyIiMQOTukaD7zg9PQeKylcNqgNjGleQV6r lbpYeUME0q6HBbvmmpFn/wH133c7IcIK76xZm81QX4vqPLKBy2OXoM2rhCBDr50RTH9W lZl0hGB5aEoJ7nYbjj90ucFq38SfQA/liLYlhPPUVt3nlPw62K9mPBL8GuAVHxYkE9qz RTxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BFTCvfyHSgTaQAqEXuiee4zBZqvRWuohWnUPgZPOJd4=; b=VMry/i3pbu8orxjsInnuQexlP1T+lPDXPBvvlv6jbburn1V7zgAuGkIZSbdEUG/kLU RsYkGGGO94PSN7ZsQ2oxfnqkHLZuX2e3+RMy71OyI9wfZM1c+l+eM8bFmpotWSf/sKDV uPO61O+lUSib/h481145UcfKacO/NsJNeGDXYpoch5iG3wKCbKqqr3ALutnyZbdzjM2b kXDpStz6ZSNRdeDLkk7g1hqvIlouif6fhMF6VAcR8eYjmo9w/6PnCA9qCrlXixv+a1a5 szSyF+7gCsHucb3z6CsHsY2VLpKqI1YhGJFTdBvC2s3+2dOPDonNpsmfdlwc+mI0+qd/ YUBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vwoj0old; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si10411284otk.171.2020.01.02.14.31.57; Thu, 02 Jan 2020 14:32:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vwoj0old; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730001AbgABWaP (ORCPT + 99 others); Thu, 2 Jan 2020 17:30:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:57640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729842AbgABW2L (ORCPT ); Thu, 2 Jan 2020 17:28:11 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F29B420863; Thu, 2 Jan 2020 22:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004091; bh=Blq+AMHt6HxK/xGxK6KR5EtA3cLwMX+jQ//LJF6rJwc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vwoj0oldSebcL8K5n34Nsxmwo1ZV7gQIH44I6uOgipfu/Z8IyRju7JIG14v7zTPVc ulvsZRIjmshN7wSZyp9i4eaCh2pE5SCWc7oCskFRir6vJWPG/grDMn9VSIcboPS5g4 2D2EJqJEKN6Upuu+BcJ6TWTewvXyRKqEFoUy+17c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leo Yan , Alexander Shishkin , Jiri Olsa , Mark Rutland , Namhyung Kim , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.9 033/171] perf test: Report failure for mmap events Date: Thu, 2 Jan 2020 23:06:04 +0100 Message-Id: <20200102220551.587940572@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.960200039@linuxfoundation.org> References: <20200102220546.960200039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leo Yan [ Upstream commit 6add129c5d9210ada25217abc130df0b7096ee02 ] When fail to mmap events in task exit case, it misses to set 'err' to -1; thus the testing will not report failure for it. This patch sets 'err' to -1 when fails to mmap events, thus Perf tool can report correct result. Fixes: d723a55096b8 ("perf test: Add test case for checking number of EXIT events") Signed-off-by: Leo Yan Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Link: http://lore.kernel.org/lkml/20191011091942.29841-1-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/tests/task-exit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c index b0d005d295a9..de2ddfe0f7c3 100644 --- a/tools/perf/tests/task-exit.c +++ b/tools/perf/tests/task-exit.c @@ -98,6 +98,7 @@ int test__task_exit(int subtest __maybe_unused) if (perf_evlist__mmap(evlist, 128, true) < 0) { pr_debug("failed to mmap events: %d (%s)\n", errno, str_error_r(errno, sbuf, sizeof(sbuf))); + err = -1; goto out_delete_evlist; } -- 2.20.1