Received: by 2002:a17:90a:9103:0:0:0:0 with SMTP id k3csp11803111pjo; Thu, 2 Jan 2020 14:33:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwHqUzmUtRtwH+NkvC0pxN0w2i1I8snleYNjU5rluuWgXaVdo5e5nqdaMMRc+0suLKm6s7Z X-Received: by 2002:a9d:588d:: with SMTP id x13mr89637066otg.6.1578004383905; Thu, 02 Jan 2020 14:33:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578004383; cv=none; d=google.com; s=arc-20160816; b=HHNbqRjw1fUKopMv13xxFmX4IQRjxkXFgs6YBKVmjN6PsguP2J4GDeIc9q6vpoQcDs sTkbL8GPlR3J/z20p/QuIHobjB3SSPI9PsbGy8PveIrJMik/PC9TcBWqG3Eusi6C9Cj0 EdrzkX/oRSXS8Jo+ljPd7CPoC+Z7Zuk7kDgUSo9RPJj4qNO0xekD/dEu+oN2v1dE2ui0 er2ctZNGHYXVxQ/AJOwgUp1Yt+YTMKETgizH/hCwxq7rLk4GiPzFQhNDqwFpkt8oq+tb 6/NlI3UwB5MSGrrURbEvCnRRm3cICl0OkXcThcpaEZvXhBqLgULjag3zvcGnmgA40Ope lbmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4K8Q1XwVAlUIRgLQ7035DlClu4MTbW3k3zhKSir30m8=; b=aFNkvH7P2SU6qWvMLvs//uc6RQGrAqZ7UTWA/GexzV/dKtPijiCVM7RzA/ucxbUMUF lR81GLTGsqhkfiwY+CJ3vPSVobfDN8deZBfK/exNfJ8XmcAP9cNrkuTeprseYgi1ECJG byei2k39KkRdpb6DJyISuGDMM4+KtYDtgLnsz4aU8AAUFMh22RDSTqUCpV32Cll6CCOg OvNH9WF2VP0C4qkdyEDKXJ+aXqpokYPFHLe7kClCig9nsFzqrVsTqRebH5DG2I9PrJ3Y SXvAlDE30ATZ3sSKutPeyhbumNP+uX7p3DxuvRik5i5cwmMmJYJc4LsAqU1Tuk1mqH5u 4+5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E2JVPjEf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si35127268otg.248.2020.01.02.14.32.52; Thu, 02 Jan 2020 14:33:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E2JVPjEf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730321AbgABWbm (ORCPT + 99 others); Thu, 2 Jan 2020 17:31:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:37046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730306AbgABWbj (ORCPT ); Thu, 2 Jan 2020 17:31:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2FFF21835; Thu, 2 Jan 2020 22:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004299; bh=jfEC8rJhOwM5jSDSuLARnYGItx2PhCRc3wve5ssCMK4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E2JVPjEf+Yi3R3pl7e1/msrzjN5+OHX5AJPnOM08FHvkxA7kcdiwjKWWSYrcshjy1 Xsfuq3gQ0Qcodv3j2Z5Bmgv2Jw1oOfoPaorBVLwbMmCN89VZEF11hfMur//ZHLQkz4 68Q6RmWZOqgb+KmdMBEslMQBXiiUGUibdQC3XS30= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Corentin Labbe , Christoph Hellwig , Marek Szyprowski , Sasha Levin Subject: [PATCH 4.9 120/171] dma-debug: add a schedule point in debug_dma_dump_mappings() Date: Thu, 2 Jan 2020 23:07:31 +0100 Message-Id: <20200102220603.732883004@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.960200039@linuxfoundation.org> References: <20200102220546.960200039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit 9ff6aa027dbb98755f0265695354f2dd07c0d1ce ] debug_dma_dump_mappings() can take a lot of cpu cycles : lpk43:/# time wc -l /sys/kernel/debug/dma-api/dump 163435 /sys/kernel/debug/dma-api/dump real 0m0.463s user 0m0.003s sys 0m0.459s Let's add a cond_resched() to avoid holding cpu for too long. Signed-off-by: Eric Dumazet Cc: Corentin Labbe Cc: Christoph Hellwig Cc: Marek Szyprowski Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- lib/dma-debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/dma-debug.c b/lib/dma-debug.c index 8971370bfb16..4435bec55fb5 100644 --- a/lib/dma-debug.c +++ b/lib/dma-debug.c @@ -435,6 +435,7 @@ void debug_dma_dump_mappings(struct device *dev) } spin_unlock_irqrestore(&bucket->lock, flags); + cond_resched(); } } EXPORT_SYMBOL(debug_dma_dump_mappings); -- 2.20.1