Received: by 2002:a17:90a:9103:0:0:0:0 with SMTP id k3csp11817494pjo; Thu, 2 Jan 2020 14:48:41 -0800 (PST) X-Google-Smtp-Source: APXvYqybPIzFWVrlA7wyhDHYVoQwOMAkVoc4fBBYN9DafWZi5aeWRxChe7pA+QYm4ddCo+ro0zkL X-Received: by 2002:a05:6830:1e67:: with SMTP id m7mr91686512otr.262.1578005321313; Thu, 02 Jan 2020 14:48:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578005321; cv=none; d=google.com; s=arc-20160816; b=rGvAJJtf85EAX01WSsbttoAxOXezbFGRaqAoM6M8kNluPg8qj2sDxAQCd1k+He5/fT A42QEz30Tcjm072y2YAxFqpCTBFbXzHN2RgEYSf0W4MmsGsMuOv7rLFtejrzEA/fHUHh oMSmQfjBE39OkbCkH2zuNJakLjDVV6zf2LXHkmeDL4iPtFxPDlc+mCJXi1IkTvlBIyqE HwHLW+zBRh2c9U0f8cCbtGsP8K1S6brhd6emS8VqH+6c1Wy4U1Nj7f+7cXqqsBbGdTkU E3d7wyi6IqTegtXUO6mIfXrpTPftCEcjOzfR/LSXbc1nCJcB7fAvpz6r5PkOoPOLvdoi yrGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=R8hDFy0j4soq2VcDpDmYOc8uSOvAkikiXnrnYRQhpTI=; b=ivVun6NsHXPeq2NQK57SJ7lVM7cdBtOlVkZPaQ/j23E/XcWYKWKFsoCIp+PVZCy7tZ Nehm0urZSvTfR9bD7kSJUCebrBEaaDZTRdcAhPw9b8srCCS5KQFOqzYAJa2r4d+WIAJg KPFpznONWn/8yX/8+40V6i35lHbIPq8rWq4MrvQrN7Ubjnqq1Srl9n0uPoRGheeFeCQ7 0yeN1HR2e/uQ5G7Oom6eGuP1Fo8qcr4H9Z4FDIyodwryfyvVMgGRCz3wkmE5Vz98E3wl kGuMAEZuwwXk10nyWQrVamcYy8vvVl9TSM8POYQR9t5DqCHZEdbouJuWyMMqd1toh9rf +r0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lYp9poZW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 20si33381748otk.283.2020.01.02.14.48.29; Thu, 02 Jan 2020 14:48:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lYp9poZW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730083AbgABW3n (ORCPT + 99 others); Thu, 2 Jan 2020 17:29:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:60836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729763AbgABW3j (ORCPT ); Thu, 2 Jan 2020 17:29:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F51C21835; Thu, 2 Jan 2020 22:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004179; bh=MvCa2z4IbcYYzFMqERVrXJWC8cppStZn4lCDgcHEnIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lYp9poZWCto7FfunQr8qdfxP7UDm63qiYDKup4alF6Nzb9jPrPYYFBIQ5OnIIY39f NAenziga1SLkOZ72F6ZtQ0uQNqiYkRtM+PWyBtK4h5kZBm8GCnbbAkD64Sv9nZGej6 9SEKgNPpl1Wpd9flGAOe9fDZYd8G5mTABgtx3yes= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Manish Chopra , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 046/171] bnx2x: Fix PF-VF communication over multi-cos queues. Date: Thu, 2 Jan 2020 23:06:17 +0100 Message-Id: <20200102220553.349350125@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.960200039@linuxfoundation.org> References: <20200102220546.960200039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manish Chopra [ Upstream commit dc5a3d79c345871439ffe72550b604fcde9770e1 ] PF driver doesn't enable tx-switching for all cos queues/clients, which causes packets drop from PF to VF. Fix this by enabling tx-switching on all cos queues/clients. Signed-off-by: Manish Chopra Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- .../net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index c6e059119b22..e8a09d0afe1c 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -2376,15 +2376,21 @@ static int bnx2x_set_pf_tx_switching(struct bnx2x *bp, bool enable) /* send the ramrod on all the queues of the PF */ for_each_eth_queue(bp, i) { struct bnx2x_fastpath *fp = &bp->fp[i]; + int tx_idx; /* Set the appropriate Queue object */ q_params.q_obj = &bnx2x_sp_obj(bp, fp).q_obj; - /* Update the Queue state */ - rc = bnx2x_queue_state_change(bp, &q_params); - if (rc) { - BNX2X_ERR("Failed to configure Tx switching\n"); - return rc; + for (tx_idx = FIRST_TX_COS_INDEX; + tx_idx < fp->max_cos; tx_idx++) { + q_params.params.update.cid_index = tx_idx; + + /* Update the Queue state */ + rc = bnx2x_queue_state_change(bp, &q_params); + if (rc) { + BNX2X_ERR("Failed to configure Tx switching\n"); + return rc; + } } } -- 2.20.1