Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp17926629ybl; Thu, 2 Jan 2020 14:58:42 -0800 (PST) X-Google-Smtp-Source: APXvYqxOqSRL7MnSt8WP2uocIyB5ftWAj4KfowMVA6hTvHdDyvSPVjFvGHd7OsDFh/NiG0kR37Zl X-Received: by 2002:a05:6830:151a:: with SMTP id k26mr78252434otp.74.1578005922367; Thu, 02 Jan 2020 14:58:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578005922; cv=none; d=google.com; s=arc-20160816; b=epMIjbvGvCmkiVuLKCIY9pNSaV+T1XhAnvA5cfFODe+Vlob/VSXx6kg+Of/bwHLqtA 3SKyiBUL1YNPE529qj2DBIyiFuJQuXUdQBFycA+/0+UMMppss37yr2s8IAaZOISxAneu cLwYdQ43iAHy9sFzSa07FYrSXIJ1CpcctinwaTGjdhXdnwKRU1DDE6nlAOc4kXqmW3+E G3tMzD1K001988+IHKE9zE9ITwigYd0RuO6CQc1DGfDXTyS+CdoHeYmAA0OdcaAVJhrp JScqkk7+bwfM4bDuYTxLM6wUgS545ZSdNTH/81nSQ3NXLYhksvQVJvMDdfu/8u2pBP+6 nz7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YALB5iWvsMRO0t0nW6cGo/oK/en934UWTRSJFfT13Gk=; b=cbtBNe0rshekcHT+1qbZtEykUYjI8cDXZBz2jsdR0SZDKDps5LzYxqsbJ+c4tXbhEj LpryDwSKImXvBYMmr55Zt2cX9IVIEBVZc7V5fQpbg6hAQLF8lzKNq/X0sO86JzknyA7x ePrpYQStQX5dltWxeK0aRTHcjjX3WzbOnAwOlexpFk5oF5tsBt6wKO2xgpecGQ5et1pZ VkOZKklacvEnp3+RBWOane6tx4iz23MaRtskRs3VxuFyagH3ID6fFYxyH5c4cch1jnXN YMdRqEyaEcYHN/R1QHtzD3GotD4jxVHb9Ct27vXr8PTKBbHdCjPbAYimS/iBt2OKc0V7 2+Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HfXNHHhP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g138si23816012oib.190.2020.01.02.14.58.30; Thu, 02 Jan 2020 14:58:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HfXNHHhP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729020AbgABW43 (ORCPT + 99 others); Thu, 2 Jan 2020 17:56:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:33498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728416AbgABWSU (ORCPT ); Thu, 2 Jan 2020 17:18:20 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE2B722B48; Thu, 2 Jan 2020 22:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578003500; bh=JS4nCumSHXOPnUPaodSkpRD8uMS2vX+hdTN30K62b4s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HfXNHHhPhdhr+/g2XDIljxJTg7avrW0vG72NZtz1Gnmffm3iAxcagvM2wNjLR7a+S /qBn4xpZR2w2Mxq1psKkuxwDqxGeyt33Ow9tAzJM+k2TJ7v/tmO6eX2IkgIlrGze8S XArgYdNjOJmT4VM98GhHDrJYg5bSk3d93MQc0HcI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Russell King , Jakub Kicinski Subject: [PATCH 5.4 187/191] net: phylink: fix interface passed to mac_link_up Date: Thu, 2 Jan 2020 23:07:49 +0100 Message-Id: <20200102215849.625414474@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102215829.911231638@linuxfoundation.org> References: <20200102215829.911231638@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Russell King [ Upstream commit 9b2079c046a9d6c9c73a4ec33816678565ee01f3 ] A mismerge between the following two commits: c678726305b9 ("net: phylink: ensure consistent phy interface mode") 27755ff88c0e ("net: phylink: Add phylink_mac_link_{up, down} wrapper functions") resulted in the wrong interface being passed to the mac_link_up() function. Fix this up. Fixes: b4b12b0d2f02 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") Signed-off-by: Russell King Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/phylink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -444,8 +444,7 @@ static void phylink_mac_link_up(struct p pl->cur_interface = link_state.interface; pl->ops->mac_link_up(pl->config, pl->link_an_mode, - pl->phy_state.interface, - pl->phydev); + pl->cur_interface, pl->phydev); if (ndev) netif_carrier_on(ndev);