Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp17938100ybl; Thu, 2 Jan 2020 15:10:38 -0800 (PST) X-Google-Smtp-Source: APXvYqzXVWQy8pyOaAM21eZOBnjPko652mJBd2vCNM0QvnZPn9ANajL+z2ubE4I6IGrFe6OcvVdX X-Received: by 2002:a05:6830:1e37:: with SMTP id t23mr9435540otr.16.1578006638064; Thu, 02 Jan 2020 15:10:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578006638; cv=none; d=google.com; s=arc-20160816; b=uM+c3XDSFDioKoKbcbOyNLp1cqwfWo8MwQXT9wCvusuyalJ9AsRv23tYAA3IX2D7Hr zPSfcHZArurAx3/dhi8u5YG80pcE28ZUYc3inM/JpizRd0btpEO4hQCzjpRhGa5/qOKk 24RdjBENyy2Y3pJgIBw6RdLPU1SZSxKFmrw+aVfaVikCEJpMHiO4Oft8n4tZo5jYXt8j OS6kpkueB+zi3p24RaijSINtSRRFv5VyQGQRJ22uNFaNAn62TGkU7HAtj1V96t70sD/a SMD6zaAQRKPRimdo0Yq3UJKCxVvob3vtYbBbQ+5N4V7xz9VwQO1IVEH5zkprnfSUG3s6 5FCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Z4BruFkOEzWE0Gb9YghA3Kh6c/RbvtpiABTlqoand9w=; b=aNrTy70ijYK5Y0GTzQjm1BNVEDpnyDKDc0pNFX8mm5RJ/CYC8cocA87JwW46D1el2C 6L4VoFZJSfPpYveM2VhbpIyDkOhq4y8ksb2neRZaJXWwx1RHnihcbL5Wu/fbkmXUhLC5 FPz/BzeNgAQk0A0UduBPOGP34weNtl0dBtXVcInsdu3GSCcQz99YjPYQ8cyBnpTtrMlI Ck74X1RsYERi+4yxgFprDVh4kOhYvY6ZCe2IWytTYgS8qPbuJOA3EaywcNWUTQNAPN92 2U2SBdAjpDUng+Qzb3JC8uhhrA1p8tGySjOEefd/OjK5hgmV1/3UmYAQi3CgeQAXFjyr dHLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n3LBaVzm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z12si28081157otm.189.2020.01.02.15.10.26; Thu, 02 Jan 2020 15:10:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n3LBaVzm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730077AbgABWbx (ORCPT + 99 others); Thu, 2 Jan 2020 17:31:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:37408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728581AbgABWbt (ORCPT ); Thu, 2 Jan 2020 17:31:49 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5761621835; Thu, 2 Jan 2020 22:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004308; bh=Qb3m8o3v/CT1jaIGRbSVS20mboLUBUtnyX6r/TOUIO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n3LBaVzmFbZMcrc3RXIE/j4p4qSZgn5INr9vMnjrKVneWGq8nVS2yiiEr4N3cMJvb yZWUf59JItnN5czGoioKRB8mxH5TjVMSYTvI0EAwX7D02yQtfgjx1u8Fw1hfMfenaE ZmYPNhVsdZ7a/rgUopsM19eglOTb+urtN4/axDBs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cristian Birsan , "David S. Miller" Subject: [PATCH 4.9 099/171] net: usb: lan78xx: Fix suspend/resume PHY register access error Date: Thu, 2 Jan 2020 23:07:10 +0100 Message-Id: <20200102220600.957092549@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.960200039@linuxfoundation.org> References: <20200102220546.960200039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cristian Birsan [ Upstream commit 20032b63586ac6c28c936dff696981159913a13f ] Lan78xx driver accesses the PHY registers through MDIO bus over USB connection. When performing a suspend/resume, the PHY registers can be accessed before the USB connection is resumed. This will generate an error and will prevent the device to resume correctly. This patch adds the dependency between the MDIO bus and USB device to allow correct handling of suspend/resume. Fixes: ce85e13ad6ef ("lan78xx: Update to use phylib instead of mii_if_info.") Signed-off-by: Cristian Birsan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/lan78xx.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1763,6 +1763,7 @@ static int lan78xx_mdio_init(struct lan7 dev->mdiobus->read = lan78xx_mdiobus_read; dev->mdiobus->write = lan78xx_mdiobus_write; dev->mdiobus->name = "lan78xx-mdiobus"; + dev->mdiobus->parent = &dev->udev->dev; snprintf(dev->mdiobus->id, MII_BUS_ID_SIZE, "usb-%03d:%03d", dev->udev->bus->busnum, dev->udev->devnum);