Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp17939832ybl; Thu, 2 Jan 2020 15:12:41 -0800 (PST) X-Google-Smtp-Source: APXvYqxEM59NcWTkmh/0voJUU/9VLenvKsa9fR/gFZeceKeLmMMUnKQ1lm0e7+0aEzsGjoEDZDzN X-Received: by 2002:a05:6830:121a:: with SMTP id r26mr87543926otp.225.1578006761410; Thu, 02 Jan 2020 15:12:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578006761; cv=none; d=google.com; s=arc-20160816; b=tRrJGr/FY9sfu9oQklhqTiQCbphtmGfRCt6AbOLIHEbGsLE820dhYC7ClgNBog6iYP JIyzVMJjR+5QVHrwxYfee466KoZoe8fyGuoifpG+qehxPMF/HQs1wf8UAM9SY38OVsTs M1ooXpgKXRLa4D+7DXUqsD0/sYebD9SBL2NDlYUYpW91UuXlVVW5oGlBSbelgrSUBCGZ hTRO2RLYYOkBafHSVgP2IjeMtUysUFNML+idM2mBc/NSpEAFSqB4VFe4CvJHph6yQX8j cSmbu9u5gF8t19JtfoO9P00ZXvIIkaS39qiCEuPtn5Fi/izbV7IjKh7bCyYR7QSpHLsg sk7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=a/Mc1WZF4XFCNGYq3H1doCkd+JrRFaoEduydxFI+9+4=; b=wvZuDJb/zWwb9N0r5wgMK+1RU8bHs9/L/FReboyufGWOfpRUitwCafe7msBvmO12B5 kHwdyOnDqp+KYgmcq5mUs9zPf850AoWmruoDbd3AhKKwynV54/mbfMbsaNf96TT3GVoe 0JvsRMN6cLrUUm8GTK7VbfGcz9gEfRm1+ZXEFBGTaDm44b4BV4q9nZG4l5HP5hxNp+bv Daqs9ar+jXV3eb1Qf89doWhh3YANaJeUAINSDAm15F9c5+4C3uLt7oFWBeJ81Hdgd1nv mGRDougITJiiEVAI7IA0TqC1LKjgKYMOPds4p9+8z3kf/SxySMviP/jYC/qh7h1OEL0Z cheQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="heINmV/T"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s6si28839762otp.126.2020.01.02.15.12.29; Thu, 02 Jan 2020 15:12:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="heINmV/T"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730506AbgABWom (ORCPT + 99 others); Thu, 2 Jan 2020 17:44:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:39842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730336AbgABWc4 (ORCPT ); Thu, 2 Jan 2020 17:32:56 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52C3021835; Thu, 2 Jan 2020 22:32:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004375; bh=+74P8MMxOQETzEH5GZB2WhF2h8TPvZSqXVt137Hd8dw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=heINmV/TlMJl7lYHcgZoRBH1oe6zPjVltCJyMYl31xnIiGdBpOI7FzOpAYl4TZOXK yrrRkEifr1Q69V1GVdOU5onqbSTW3n2PU/6/2aoyvh8CQgMOwzAF5b1AHp2frZqtQA 3KvxykM+wy0jzVjB/KTDwmG4NsYhvjM+PVzPApAk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephen Boyd , Jeffrey Hugo , Sasha Levin Subject: [PATCH 4.9 127/171] clk: qcom: Allow constant ratio freq tables for rcg Date: Thu, 2 Jan 2020 23:07:38 +0100 Message-Id: <20200102220604.670497536@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.960200039@linuxfoundation.org> References: <20200102220546.960200039@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeffrey Hugo [ Upstream commit efd164b5520afd6fb2883b68e0d408a7de29c491 ] Some RCGs (the gfx_3d_src_clk in msm8998 for example) are basically just some constant ratio from the input across the entire frequency range. It would be great if we could specify the frequency table as a single entry constant ratio instead of a long list, ie: { .src = P_GPUPLL0_OUT_EVEN, .pre_div = 3 }, { } So, lets support that. We need to fix a corner case in qcom_find_freq() where if the freq table is non-null, but has no frequencies, we end up returning an "entry" before the table array, which is bad. Then, we need ignore the freq from the table, and instead base everything on the requested freq. Suggested-by: Stephen Boyd Signed-off-by: Jeffrey Hugo Link: https://lkml.kernel.org/r/20191031185715.15504-1-jeffrey.l.hugo@gmail.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/qcom/clk-rcg2.c | 2 ++ drivers/clk/qcom/common.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c index a071bba8018c..0ae1b0a66eb5 100644 --- a/drivers/clk/qcom/clk-rcg2.c +++ b/drivers/clk/qcom/clk-rcg2.c @@ -196,6 +196,8 @@ static int _freq_tbl_determine_rate(struct clk_hw *hw, p = clk_hw_get_parent_by_index(hw, index); if (clk_flags & CLK_SET_RATE_PARENT) { if (f->pre_div) { + if (!rate) + rate = req->rate; rate /= 2; rate *= f->pre_div + 1; } diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index fffcbaf0fba7..f89a9f0aa606 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -37,6 +37,9 @@ struct freq_tbl *qcom_find_freq(const struct freq_tbl *f, unsigned long rate) if (!f) return NULL; + if (!f->freq) + return f; + for (; f->freq; f++) if (rate <= f->freq) return f; -- 2.20.1