Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: BAQUOTBsbivz+hOSvQIkiE0F2giY4ePtjLtw5YXtoBL3uh7gaLv/4mzrQviGt6H5Qc09VMm7cP
 xQ9RtbYa29K0U2CMdgCoNSjX+NRefWtwfNWVYMC6OeOH4CzcwfU9FUSi+HiLieMW7au4boFSyT
 2spNgk6m07S+kQbkaeNP0bZp/PnO+NzHXNS/a8hakvVkCO4A/lDkKKeRgv9c5Vu6wZi3e5v3Xg
 rRIWZHNsv1KaXGsa4rNhCT6ICOi1nfDcsEgsFHXDocxesJevQ/GT2GclYts3XDzsK4FDzKRHxz
 MyM=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Balbir Singh <sblbir@amazon.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
CC:     "axboe@kernel.dk" <axboe@kernel.dk>,
        "ssomesh@amazon.com" <ssomesh@amazon.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "hch@lst.de" <hch@lst.de>, "mst@redhat.com" <mst@redhat.com>
Subject: Re: [resend v1 1/5] block/genhd: Notify udev about capacity change
Thread-Topic: [resend v1 1/5] block/genhd: Notify udev about capacity change
Thread-Index: AQHVwUG9qzxAaxFzwka5YkVHh6Dxxg==
Date:   Fri, 3 Jan 2020 06:16:39 +0000
Message-ID: <BYAPR04MB5749EE1549B30FCECEC1154B86230@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20200102075315.22652-1-sblbir@amazon.com>
 <20200102075315.22652-2-sblbir@amazon.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 266f1800-e0c7-4fa3-7e22-08d790147ed5
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2020 06:16:39.6961
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BJSzvi4TeV5gwBjkoTJ5icjd8Ssy+mEpIkXgYVmGpqol6hT0iVBy2MzOCtpXEf12EVRWfbQ8j0Xp6T1K3vIdFaLDfLsmrrmCjc+jXmknalw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB6088
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/01/2020 11:53 PM, Balbir Singh wrote:=0A=
> Allow block/genhd to notify user space (via udev) about disk size changes=
=0A=
> using a new helper disk_set_capacity(), which is a wrapper on top=0A=
> of set_capacity(). disk_set_capacity() will only notify via udev if=0A=
> the current capacity or the target capacity is not zero.=0A=
>=0A=
> Suggested-by: Christoph Hellwig<hch@lst.de>=0A=
> Signed-off-by: Someswarudu Sangaraju<ssomesh@amazon.com>=0A=
> Signed-off-by: Balbir Singh<sblbir@amazon.com>=0A=
> ---=0A=
=0A=
Since disk_set_capacity(() is on the same line as set_capacity()=0A=
we should follow the same convention, which is :-=0A=
=0A=
1. Avoid exporting symbol.=0A=
2. Mark new function in-line.=0A=
=0A=
Unless there is a very specific reason for breaking the pattern.=0A=
=0A=
Why not this (totally untested but easy convey above comment)=0A=
on the top of this patch ?=0A=
=0A=
# git diff=0A=
diff --git a/block/genhd.c b/block/genhd.c=0A=
index 94faec98607b..ff6268970ddc 100644=0A=
--- a/block/genhd.c=0A=
+++ b/block/genhd.c=0A=
@@ -46,25 +46,6 @@ static void disk_add_events(struct gendisk *disk);=0A=
  static void disk_del_events(struct gendisk *disk);=0A=
  static void disk_release_events(struct gendisk *disk);=0A=
=0A=
-/*=0A=
- * Set disk capacity and notify if the size is not currently=0A=
- * zero and will not be set to zero=0A=
- */=0A=
-void disk_set_capacity(struct gendisk *disk, sector_t size)=0A=
-{=0A=
-       sector_t capacity =3D get_capacity(disk);=0A=
-=0A=
-       set_capacity(disk, size);=0A=
-       if (capacity !=3D 0 && size !=3D 0) {=0A=
-               char *envp[] =3D { "RESIZE=3D1", NULL };=0A=
-=0A=
-               kobject_uevent_env(&disk_to_dev(disk)->kobj, =0A=
KOBJ_CHANGE, envp);=0A=
-       }=0A=
-}=0A=
-=0A=
-EXPORT_SYMBOL_GPL(disk_set_capacity);=0A=
-=0A=
-=0A=
  void part_inc_in_flight(struct request_queue *q, struct hd_struct =0A=
*part, int rw)=0A=
  {=0A=
         if (queue_is_mq(q))=0A=
diff --git a/include/linux/genhd.h b/include/linux/genhd.h=0A=
index d5e87d7cc357..5e595a28f893 100644=0A=
--- a/include/linux/genhd.h=0A=
+++ b/include/linux/genhd.h=0A=
@@ -469,6 +469,22 @@ static inline void set_capacity(struct gendisk =0A=
*disk, sector_t size)=0A=
         disk->part0.nr_sects =3D size;=0A=
  }=0A=
=0A=
+/*=0A=
+ * Set disk capacity and notify if the size is not currently=0A=
+ * zero and will not be set to zero=0A=
+ */=0A=
+static inline void disk_set_capacity(struct gendisk *disk, sector_t size)=
=0A=
+{=0A=
+       sector_t capacity =3D get_capacity(disk);=0A=
+=0A=
+       set_capacity(disk, size);=0A=
+       if (capacity !=3D 0 && size !=3D 0) {=0A=
+               char *envp[] =3D { "RESIZE=3D1", NULL };=0A=
+=0A=
+               kobject_uevent_env(&disk_to_dev(disk)->kobj, =0A=
KOBJ_CHANGE, envp);=0A=
+       }=0A=
+}=0A=
+=0A=
  #ifdef CONFIG_SOLARIS_X86_PARTITION=0A=
=0A=
=0A=