Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp18302032ybl; Thu, 2 Jan 2020 23:03:40 -0800 (PST) X-Google-Smtp-Source: APXvYqyn7YTJ9MW4BQ1eyIN2sC1E0RjUM+5gKrV1sTiUhSmveEJ7n+MyBYhep+rGDmlMPrbpa7QW X-Received: by 2002:aca:5745:: with SMTP id l66mr3898994oib.3.1578035020014; Thu, 02 Jan 2020 23:03:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578035020; cv=none; d=google.com; s=arc-20160816; b=cB0zNb3vWCtnK4IgbkQfMI4BgolLWc0OQuO9A/pOim1NWc/idcYWwhO2U/G9izRHU9 bJUIFbfPKcZ2rOEu0juAToTruzNN4eD94bjblUE+GkwsAYi5BJmEGh1dVnDIb/pVnDQ1 3dK/S+SKsQ2B/NsizRSLSQBltid8+RkfF5RT4vJ23xg4l7GIBogtQ9FqCY2Si3DQi5e6 qWqUgUVyg7423fMf/ePwFidLjDH/32Jtrclmc1mDhpjGJ0GFo54dqWoiaAFXgP3Bu39L t6+wWtHm48d0Ou95P/5EhObmhz9aHC+RL/JN1U1m6HrmO3pXpJ1DkG4L+lhhDD7al960 kJCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NsQH7ndpF38Shh3J6h3vrfW8wp5BH19Yb1KRCuQlejE=; b=zfoLZRJG4dkRJHtkmoHTZiJujrMpULKDCMd7HaHgz0E3PXEscLbvUPpQ88d7MOuhH8 Fd7Js8XuITm7IDGKiS3Gbn0OyvKSo/Iu1rnirfJ5awBB7W+Uj3061oGN09iLEhEtfZRR zMuekJR9yvWBBebVv/YC/TXtQNii/EJxGXEvST/7vgoNU4i7Vqcys+OxJJDLqfZIvUwd xMHCGOhFloYR6ILbManoVQtACYRDJWAPP7sU19OtVv625+5w1ZFp5BlfDc5u5POYChvz HX1klLsGc2rOqkM1LWV0Mj7HUq/MmS2LY08QlnTXlABDOKga6hXgrjBweMu/qEuQgOKU LWig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zdcaZLsM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si25595538oic.12.2020.01.02.23.03.26; Thu, 02 Jan 2020 23:03:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zdcaZLsM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727404AbgACHAo (ORCPT + 99 others); Fri, 3 Jan 2020 02:00:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:47002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgACHAm (ORCPT ); Fri, 3 Jan 2020 02:00:42 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADFE62464E; Fri, 3 Jan 2020 07:00:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578034842; bh=we7pKnlhkto10e/KX0lmPcqpyOhRRQPuUUaKyEjfmD0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zdcaZLsMEgkBS2zxyaU39JEf20w66MI6AjBLdLztuJa28i5IUrXCuXH+/Cga1gOed RCQ6JeJGNc+n4KbxgLJlB3Z9xggRW3mGMmbEdr858fnzD4MMuwkIPXavACWhCoYQ/9 2DDsgJcH2KIH6aq0pKlZwtmfNQK+4StxIXnCm/lo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Benoit Parrot , "Lad, Prabhakar" , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 013/137] media: i2c: ov2659: Fix missing 720p register config Date: Thu, 2 Jan 2020 23:06:26 +0100 Message-Id: <20200102220548.514572546@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.618583146@linuxfoundation.org> References: <20200102220546.618583146@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benoit Parrot [ Upstream commit 9d669fbfca20e6035ead814e55d9ef1a6b500540 ] The initial registers sequence is only loaded at probe time. Afterward only the resolution and format specific register are modified. Care must be taken to make sure registers modified by one resolution setting are reverted back when another resolution is programmed. This was not done properly for the 720p case. Signed-off-by: Benoit Parrot Acked-by: Lad, Prabhakar Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov2659.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index 4f43e8c43950..6eefb8bbb5b5 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -419,10 +419,14 @@ static struct sensor_register ov2659_720p[] = { { REG_TIMING_YINC, 0x11 }, { REG_TIMING_VERT_FORMAT, 0x80 }, { REG_TIMING_HORIZ_FORMAT, 0x00 }, + { 0x370a, 0x12 }, { 0x3a03, 0xe8 }, { 0x3a09, 0x6f }, { 0x3a0b, 0x5d }, { 0x3a15, 0x9a }, + { REG_VFIFO_READ_START_H, 0x00 }, + { REG_VFIFO_READ_START_L, 0x80 }, + { REG_ISP_CTRL02, 0x00 }, { REG_NULL, 0x00 }, }; -- 2.20.1