Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     =?UTF-8?Q?'Pali_Roh=C3=A1r'?= <pali.rohar@gmail.com>
Cc:     <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
        <hch@lst.de>, <sj1557.seo@samsung.com>, <linkinjeon@gmail.com>
In-Reply-To: <20200102135502.hkey7z45gnprinpp@pali>
Subject: RE: [PATCH v9 10/13] exfat: add nls operations
Date:   Fri, 3 Jan 2020 16:06:25 +0900
Message-ID: <003101d5c204$5046e9a0$f0d4bce0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Language: ko
Thread-Index: AQJSGi/S1M7UFBjz5N3SW71o+eawLwHz+Lr1AtmMBwQCoo41BaakU3fg
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20200102082036.29643-1-namjae.jeon@samsung.com>
        <CGME20200102082407epcas1p4cf10cd3d0ca2903707ab01b1cc523a05@epcas1p4.samsung.com>
        <20200102082036.29643-11-namjae.jeon@samsung.com>
        <20200102135502.hkey7z45gnprinpp@pali>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Thursday 02 January 2020 16:20:33 Namjae Jeon wrote:
> > This adds the implementation of nls operations for exfat.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon=40samsung.com>
> > Signed-off-by: Sungjong Seo <sj1557.seo=40samsung.com>
> > ---
> >  fs/exfat/nls.c =7C 809
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 809 insertions(+)
> >  create mode 100644 fs/exfat/nls.c
> >
> > diff --git a/fs/exfat/nls.c b/fs/exfat/nls.c new file mode 100644
> > index 000000000000..af52328e28ff
> > --- /dev/null
> > +++ b/fs/exfat/nls.c
>=20
> ...
>=20
> > +int exfat_nls_uni16s_to_vfsname(struct super_block *sb,
> > +		struct exfat_uni_name *uniname, unsigned char *p_cstring,
> > +		int buflen)
> > +=7B
> > +	if (EXFAT_SB(sb)->options.utf8)
> > +		return __exfat_nls_utf16s_to_vfsname(sb, uniname, p_cstring,
> > +				buflen);
> > +	return __exfat_nls_uni16s_to_vfsname(sb, uniname, p_cstring,
> buflen);
> > +=7D
>=20
> Hello, I'm looking at this function and basically it do nothing.
> Or was it supposed that this function should do something more for UTF-8
> encoding?
>=20
> There is one if- statement, but in both branches is executed exactly
> same code.
>=20
> And executed function just pass same arguments as current callee
> function.
>=20
> So calls to exfat_nls_uni16s_to_vfsname() can be replaced by direct
> calls to __exfat_nls_uni16s_to_vfsname().
Ah, The function names are similar, but not same. see utf16s/uni16s.

Thanks=21

>=20
> Or maybe better, rename __exfat_nls_uni16s_to_vfsname() function to
> exfat_nls_uni16s_to_vfsname().
>=20
> > +int exfat_nls_vfsname_to_uni16s(struct super_block *sb,
> > +		const unsigned char *p_cstring, const int len,
> > +		struct exfat_uni_name *uniname, int *p_lossy)
> > +=7B
> > +	if (EXFAT_SB(sb)->options.utf8)
> > +		return __exfat_nls_vfsname_to_utf16s(sb, p_cstring, len,
> > +				uniname, p_lossy);
> > +	return __exfat_nls_vfsname_to_uni16s(sb, p_cstring, len, uniname,
> > +			p_lossy);
> > +=7D
>=20
> And same for this function.
>=20
> --
> Pali Roh=C3=A1r=0D=0A>=20pali.rohar=40gmail.com=0D=0A=0D=0A