Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Fri, 03 Jan 2020 10:00:27 +0100
From:   Michael Walle <michael@walle.cc>
To:     Stephen Boyd <sboyd@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 2/2] clk: fsl-sai: new driver
In-Reply-To: <20200102080929.0EE2C215A4@mail.kernel.org>
References: <20191209233305.18619-1-michael@walle.cc>
 <20191209233305.18619-2-michael@walle.cc>
 <20191224080536.B0C99206CB@mail.kernel.org>
 <91275d33d6a7c9978a2c70545fde38cd@walle.cc>
 <20200102080929.0EE2C215A4@mail.kernel.org>
Message-ID: <6b092a602b3b8cf09160b1dcb4a282e6@walle.cc>
User-Agent: Roundcube Webmail/1.3.8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Stephen,

>> >> +       parent_name = of_clk_get_parent_name(node, 0);
>> >
>> > Could this use the new way of specifying clk parents so that we don't
>> > have to query DT for parent names and just let the core framework do it
>> > whenever it needs to?
>> 
>> you mean specifying parent_data with .index = 0? Seems like
>> clk_composite
>> does not support this. The parent can only be specified by supplying 
>> the
>> clock names.
>> 
>> I could add that in a separate patch. What do you think about the
>> following new functions, where a driver can use parent_data instead
>> of parent_names.
> 
> I started doing this in
> https://lkml.kernel.org/r/20190830150923.259497-1-sboyd@kernel.org but 
> I
> never got around to the composite clks. Sounds fine to add this new API
> for your use case.

Yeah took me a while to figure out what you've meant by the "new way" ;)
Anyway, I've posted a v3 of this series with the new composite clock 
API.

> 
>> 
>> +struct clk *clk_register_composite_pdata(struct device *dev, const 
>> char
>> *name,
>> +               const struct clk_parent_data *parent_data,
>> +               struct clk_hw *mux_hw, const struct clk_ops *mux_ops,
>> +               struct clk_hw *rate_hw, const struct clk_ops 
>> *rate_ops,
>> +               struct clk_hw *gate_hw, const struct clk_ops 
>> *gate_ops,
>> +               unsigned long flags);

num_parents was missing here. added that in the v3.

-michael