Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Jan 2020 12:16:55 +0100
From:   Krzysztof Kozlowski <krzk@kernel.org>
To:     Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>
Cc:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "kgene@kernel.org" <kgene@kernel.org>,
        "hminas@synopsys.com" <hminas@synopsys.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
        Amelie DELAUNAY <amelie.delaunay@st.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: exynos: Remove unneeded "snps,dwc2"
 from hsotg node
Message-ID: <20200103111655.GA1605@pi3>
References: <20191219103536.25485-1-benjamin.gaignard@st.com>
 <20191219103536.25485-3-benjamin.gaignard@st.com>
 <20191230153758.GB4918@pi3>
 <bbc7e34c-75c2-dfe0-70f3-0685e8e54fed@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bbc7e34c-75c2-dfe0-70f3-0685e8e54fed@st.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 02, 2020 at 08:50:39AM +0000, Benjamin GAIGNARD wrote:
> 
> On 12/30/19 4:37 PM, Krzysztof Kozlowski wrote:
> > On Thu, Dec 19, 2019 at 11:35:36AM +0100, Benjamin Gaignard wrote:
> >> Remove "snps,dwc2" from hsotg@12480000 node compatible list because
> >> "samsung,s3c6400-hsotg" should be enough.
> > The more detailed compatible is almost always "enough". Some other nodes
> > also have detailed+generic compatible. In this case there is a driver
> > matching "snps,dwc2" so why removing it?
> 
> First because, unlike the others dwc2 devices, this compatible wasn't 
> describe in the bindings file
> 
> so I had to investigated how it should work and, on samsung DT files, 
> only "samsung,s3c6400-hsotg".
> 
>  From driver code point of view that seems coherent (we do the same for 
> stm32).
> 
> With that in mind I have decided to remove "snps,dwc2" from exynos DT 
> file rather than add it everywhere else.
>

Actually fine with me, although I would be happy if Rob or Mark could
confirm that it is a preferred approach.

Rob, Mark, could you share your thoughts?

Best regards,
Krzysztof