Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] video/fbdev/68328fb: Remove dead code
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sabyasachi.linux@gmail.com
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Message-ID: <dc887c33-0374-34e7-8d0d-329b87a5a7c3@samsung.com>
Date:   Fri, 3 Jan 2020 13:02:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <1567428544-8620-1-git-send-email-jrdr.linux@gmail.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20190902124317epcas1p3933aec8ee7e526f3f42dd9f08ce6bdb0@epcas1p3.samsung.com>
        <1567428544-8620-1-git-send-email-jrdr.linux@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 9/2/19 2:49 PM, Souptick Joarder wrote:
> This is dead code since 3.15. If their is no plan to
> use it further, these can be removed forever.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/68328fb.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c
> index d48e960..02d22b7 100644
> --- a/drivers/video/fbdev/68328fb.c
> +++ b/drivers/video/fbdev/68328fb.c
> @@ -405,20 +405,8 @@ static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
>  
>  int __init mc68x328fb_setup(char *options)
>  {
> -#if 0
> -	char *this_opt;
> -#endif
> -
>  	if (!options || !*options)
>  		return 1;
> -#if 0
> -	while ((this_opt = strsep(&options, ",")) != NULL) {
> -		if (!*this_opt)
> -			continue;
> -		if (!strncmp(this_opt, "disable", 7))
> -			mc68x328fb_enable = 0;
> -	}
> -#endif
>  	return 1;
>  }
>