Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] objtool: use $(SRCARCH) to avoid compile error with
 ARCH=x86_64
To:     Shile Zhang <shile.zhang@linux.alibaba.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org
References: <20191227022931.142690-1-shile.zhang@linux.alibaba.com>
From:   Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Date:   Fri, 3 Jan 2020 18:18:30 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20191227022931.142690-1-shile.zhang@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Message-Id: <3c752455-3fd3-b146-84c5-472574a3667e@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/27/19 7:59 AM, Shile Zhang wrote:
> To build objtool with ARCH=x86_64 will failed as:
> 
>    $make ARCH=x86_64 -C tools/objtool
>    ...
>      CC       arch/x86/decode.o
>    arch/x86/decode.c:10:22: fatal error: asm/insn.h: No such file or directory
>     #include <asm/insn.h>
>                          ^
>    compilation terminated.
>    mv: cannot stat ‘arch/x86/.decode.o.tmp’: No such file or directory
>    make[2]: *** [arch/x86/decode.o] Error 1
>    ...
> 
> The root cause is the command-line variable 'ARCH' cannot be overridden.
> It can be replaced by the one 'SRCARCH' defined in
> 'tools/scripts/Makefile.arch'.
> 
> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>

Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>


-- 
Kamalesh