Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp18564321ybl; Fri, 3 Jan 2020 04:57:33 -0800 (PST) X-Google-Smtp-Source: APXvYqyACjvNKdHO69JSYwLvPRQgiByvwHT+eLspTwG37zgWqXloKkjnDOwrPvcIr/WYmE55CtCU X-Received: by 2002:a05:6830:1f89:: with SMTP id v9mr93509687otr.90.1578056253106; Fri, 03 Jan 2020 04:57:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578056253; cv=none; d=google.com; s=arc-20160816; b=O5/P3we5mIk5r2C8ABwe0hKJzwQ1mNCOtVun9Dv1PdPvrhoxjc8XYZc+dXrGN6WPWm G3MaECsE4Ci+bO98YGaJtwhqo0mNALUX3DdoYGCoCjEtlxWLBo87mEZe9mIgSvvRh/I6 aWqcPJy/Uv6NnfLP0s7YfbiVSqRSeF+C50eieN4/udaEvOQDvVlxRofGPArHgM98Z0GC F4IG6Zo5tBn+SYdiWxO8Y9qel7mkfbeZCA2RmFJCD2KxVBbHLYmrt/CTe6tzThqDchPe sTTDfhcGDiDing2f/uf7BIvBFt5CMg1jW8wiT7Q+RN3EcwgDC/XQNeLJJ+B5ADsMSPMB /kGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Wda5/QQ/lZcy20YykGuQFXFwBet5NlNxUkhBvzVVF20=; b=Hq13lil9QzNDXP3xBdvn6rIpZtal8YoaURnLQC04V9JMudDEUSZP2OAPK0aDrACNeR XJ5GiEQPS9GCzuuUcbWB5bQz1vWpvYLFAfEblEpYMAYFF9SOQikur7sn/0vnHfUIfWHM 7RVVzbm0xrpnl1GeobX5U7PZBegRO95RVaxo8mHn+BGggMXV/Tq5gjfLGUYORK9khMyL 8uMiWeWlZy9MehfhFMnvS0U7x/YK78kM1oi+yGWblh50CJvvBSp5UQwrrgfQh8xfCPia uZRbQyaJc3T2kItDnHV4RwZqEZlfzlLO1mBYs0h36PfbGjHbx+NnMeznZ/abPyhmLdre M3UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Off8t2I1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9si30283087otq.68.2020.01.03.04.57.20; Fri, 03 Jan 2020 04:57:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Off8t2I1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727737AbgACM4B (ORCPT + 99 others); Fri, 3 Jan 2020 07:56:01 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:39148 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727523AbgACM4B (ORCPT ); Fri, 3 Jan 2020 07:56:01 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 003CsVvF111253; Fri, 3 Jan 2020 12:55:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=Wda5/QQ/lZcy20YykGuQFXFwBet5NlNxUkhBvzVVF20=; b=Off8t2I1g7CRnFrKnqxOSJgFVvKD4a4C7FgjX8B4JnfhOl7JWft8L51VF5R4utAQGQPb tGualgGfZ7jh41aN4WyxtAeTigmolthOcYMABDbJEWr76kabwhMfanE1gzoC14b9M3WC UVuGRGjAGK2hUl7MovK6XZh5DSpHGB8UJLCV8de3uVEjDCFeQJZgRQC4cz+98R/4S7YS FxzO9XIFKfjcO0cZS9+taJOr18tk+f1QnZyZOHhPqtwti67oOA9RCS+1UxxuaUlCoUpT CLkgkm47Q+769mgakb2GmLl7MifsFBXU2ezWag2qABx8UwfSzHMF3ZGo92EY+l6bxfDg Ww== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2x5ypqv5yf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 Jan 2020 12:55:33 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 003CsQPx123409; Fri, 3 Jan 2020 12:55:32 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2xa5fg96fw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 Jan 2020 12:55:32 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 003CtVX6019787; Fri, 3 Jan 2020 12:55:31 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 03 Jan 2020 04:55:30 -0800 Date: Fri, 3 Jan 2020 15:55:21 +0300 From: Dan Carpenter To: Luc Van Oostenryck Cc: Kees Cook , Eric Biggers , Peter Zijlstra , linux-kernel@vger.kernel.org, Ingo Molnar , Will Deacon , Elena Reshetova , Thomas Gleixner , Anna-Maria Gleixner , Sebastian Andrzej Siewior , linux-sparse@vger.kernel.org Subject: Re: [PATCH] locking/refcount: add sparse annotations to dec-and-lock functions Message-ID: <20200103125521.GJ3911@kadam> References: <20191226152922.2034-1-ebiggers@kernel.org> <20191228114918.GU2827@hirez.programming.kicks-ass.net> <201912301042.FB806E1133@keescook> <20191230191547.GA1501@zzz.localdomain> <201912301131.2C7C51E8C6@keescook> <20191230233814.2fgmsgtnhruhklnu@ltop.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191230233814.2fgmsgtnhruhklnu@ltop.local> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9488 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001030123 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9488 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001030123 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I re-wrote Smatch's locking check last month to use the cross function DB. Now Smatch can parse refcount_dec_and_lock() directly without any modifications or annotations. regards, dan carpenter