Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp18788944ybl; Fri, 3 Jan 2020 09:04:18 -0800 (PST) X-Google-Smtp-Source: APXvYqzbUVAkzhoITnZ2Hl4NtwPgNp+DST8qU2uKCOfMpd/WcUp7gfBUqOa3YUKfdrAmhh1v0F9E X-Received: by 2002:aca:4309:: with SMTP id q9mr4488619oia.158.1578071058236; Fri, 03 Jan 2020 09:04:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578071058; cv=none; d=google.com; s=arc-20160816; b=piSlGslKCicHbijjvvIz+EuGqKd6Us7wApuz83lNgQDlOjR3rkNInPHe1hJlQD/o6A tMu96NOxJBfzPEnBBGalePC/BOz2xWM3hlno0w05mtUgwGE1hgMVC0WnmrOrzvNYJUw0 FsPzDcNSJES9ATZYXnJfctQy0upMlZ+t3ppyelDvloMCaj0FAmuhuyTlElgqKohnD0ZL q7S8/pKBIF6vSid48U7gopRTZbMRHZc1STwg6TuDy0vVFZHPIqhF6pp9XDAYbU6Fzl8/ xhG67E95kCJSwQGDI1Zinbn4IT+upwHs5BSDB2NhYiam+fweB37n21hu0Mzz1zQYEPZd dAiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to :subject:cc:to:from:date; bh=cNiozmcii9FjNO0b19Oss1eUJcoXYA7n14KuxI2obZ4=; b=R48IeOf2jht8AdgrWQYfiZSkLWevkA0pKatbqnjKSty/RvIMYOkzsLBmiBPJt6KTaL Bn5VsI9BjbsVNXaaIGANASMlDNM84IHznnvAOMr4S/Z9Q2YwGEp0bEcTZtBxiloFLzqR 9eryqTt+evWbQBtsASrZrSrcOzsKB1GTULBDLqDMK91TY/hCfpHgbyFs1UJAt7hP2Ea4 HAXfXdqAfc1T5ehgeTmjoHoWw8wE0qt5Y5ehP9/WnwFQ0TnGTAIGNTme39Ys5v36EawH nehFEsF94wfM0BIPbH/jmzJg/jkydJHWbtrbs6IqUXv7td6h3677ed7Sv8YeO4lXkxqN fYjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8si26464180oib.104.2020.01.03.09.04.05; Fri, 03 Jan 2020 09:04:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbgACRBp (ORCPT + 99 others); Fri, 3 Jan 2020 12:01:45 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:34962 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727912AbgACRBp (ORCPT ); Fri, 3 Jan 2020 12:01:45 -0500 Received: (qmail 5214 invoked by uid 2102); 3 Jan 2020 12:01:44 -0500 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 3 Jan 2020 12:01:44 -0500 Date: Fri, 3 Jan 2020 12:01:44 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: andreyknvl@google.com, syzbot cc: gregkh@linuxfoundation.org, , , Kernel development list , USB list , Subject: Re: WARNING in usbhid_raw_request/usb_submit_urb (2) In-Reply-To: <000000000000d29687059b3f32aa@google.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Jan 2020, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger > crash: > > Reported-and-tested-by: > syzbot+10e5f68920f13587ab12@syzkaller.appspotmail.com > > Tested on: > > commit: ecdf2214 usb: gadget: add raw-gadget interface > git tree: https://github.com/google/kasan.git > kernel config: https://syzkaller.appspot.com/x/.config?x=b06a019075333661 > dashboard link: https://syzkaller.appspot.com/bug?extid=10e5f68920f13587ab12 > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > patch: https://syzkaller.appspot.com/x/patch.diff?x=177f06e1e00000 > > Note: testing is done by a robot and is best-effort only. Andrey: Clearly something strange is going on here. First, the patch should not have changed the behavior; all it did was add some log messages. Second, I don't see how the warning could have been triggered at all -- it seems to be complaining that 2 != 2. Does the reproducer really work? Alan Stern