Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Jan 2020 19:36:04 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Namjae Jeon <linkinjeon@gmail.com>
Cc:     Namjae Jeon <namjae.jeon@samsung.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
        sj1557.seo@samsung.com
Subject: Re: [PATCH v9 09/13] exfat: add misc operations
Message-ID: <20200103183604.xzfvnu2qivqnqkkx@pali>
References: <20200102082036.29643-1-namjae.jeon@samsung.com>
 <CGME20200102082406epcas1p268f260d90213bdaabee25a7518f86625@epcas1p2.samsung.com>
 <20200102082036.29643-10-namjae.jeon@samsung.com>
 <20200102091902.tk374bxohvj33prz@pali>
 <CAKYAXd_9XOWtcLYk-+gg636rFCYjLgHzrP5orR3XjXGMpTKWLA@mail.gmail.com>
 <20200102114034.bjezqs45xecz4atd@pali>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="63ohlbp4gwxokjqp"
Content-Disposition: inline
In-Reply-To: <20200102114034.bjezqs45xecz4atd@pali>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--63ohlbp4gwxokjqp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thursday 02 January 2020 12:40:34 Pali Roh=C3=A1r wrote:
> On Thursday 02 January 2020 20:30:03 Namjae Jeon wrote:
> > 2020-01-02 18:19 GMT+09:00, Pali Roh=C3=A1r <pali.rohar@gmail.com>:
> > > On Thursday 02 January 2020 16:20:32 Namjae Jeon wrote:
> > >> This adds the implementation of misc operations for exfat.
> > >>
> > >> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> > >> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> > >> ---
> > >>  fs/exfat/misc.c | 253 +++++++++++++++++++++++++++++++++++++++++++++=
+++
> > >>  1 file changed, 253 insertions(+)
> > >>  create mode 100644 fs/exfat/misc.c
> > >>
> > >> diff --git a/fs/exfat/misc.c b/fs/exfat/misc.c
> > >> new file mode 100644
> > >> index 000000000000..7f533bcb3b3f
> > >> --- /dev/null
> > >> +++ b/fs/exfat/misc.c
> > >
> > > ...
> > >
> > >> +/* <linux/time.h> externs sys_tz
> > >> + * extern struct timezone sys_tz;
> > >> + */
> > >> +#define UNIX_SECS_1980    315532800L
> > >> +
> > >> +#if BITS_PER_LONG =3D=3D 64
> > >> +#define UNIX_SECS_2108    4354819200L
> > >> +#endif
> > >
> > > ...
> > >
> > >> +#define TIMEZONE_CUR_OFFSET()	((sys_tz.tz_minuteswest / (-15)) & 0x=
7F)
> > >> +/* Convert linear UNIX date to a FAT time/date pair. */
> > >> +void exfat_time_unix2fat(struct exfat_sb_info *sbi, struct timespec=
64
> > >> *ts,
> > >> +		struct exfat_date_time *tp)
> > >> +{
> > >> +	time_t second =3D ts->tv_sec;
> > >> +	time_t day, month, year;
> > >> +	time_t ld; /* leap day */
> > >
> > > Question for other maintainers: Has kernel code already time_t defined
> > > as 64bit? Or it is still just 32bit and 32bit systems and some time64=
_t
> > > needs to be used? I remember that there was discussion about these
> > > problems, but do not know if it was changed/fixed or not... Just a
> > > pointer for possible Y2038 problem. As "ts" is of type timespec64, but
> > > "second" of type time_t.
> > My bad, I will change it with time64_t.
>=20
> Now I have looked into sources and time_t is just typedef from
> __kernel_old_time_t type. So it looks like that time64_t is the type
> which should be used in new code.
>=20
> But somebody else should confirm this information.
>=20
> > >
> > >> +
> > >> +	/* Treats as local time with proper time */
> > >> +	second -=3D sys_tz.tz_minuteswest * SECS_PER_MIN;
> > >> +	tp->timezone.valid =3D 1;
> > >> +	tp->timezone.off =3D TIMEZONE_CUR_OFFSET();
> > >> +
> > >> +	/* Jan 1 GMT 00:00:00 1980. But what about another time zone? */
> > >> +	if (second < UNIX_SECS_1980) {
> > >> +		tp->second  =3D 0;
> > >> +		tp->minute  =3D 0;
> > >> +		tp->hour =3D 0;
> > >> +		tp->day  =3D 1;
> > >> +		tp->month  =3D 1;
> > >> +		tp->year =3D 0;
> > >> +		return;
> > >> +	}
> > >> +
> > >> +	if (second >=3D UNIX_SECS_2108) {
> > >
> > > Hello, this code cause compile errors on 32bit systems as UNIX_SECS_2=
108
> > > macro is not defined when BITS_PER_LONG =3D=3D 32.
> > >
> > > Value 4354819200 really cannot fit into 32bit signed integer, so you
> > > should use 64bit signed integer. I would suggest to define this macro
> > > value via LL not just L suffix (and it would work on both 32 and 64bi=
t)
> > Okay.
> > >
> > >   #define UNIX_SECS_2108    4354819200LL
> > >
> > >> +		tp->second  =3D 59;
> > >> +		tp->minute  =3D 59;
> > >> +		tp->hour =3D 23;
> > >> +		tp->day  =3D 31;
> > >> +		tp->month  =3D 12;
> > >> +		tp->year =3D 127;
> > >> +		return;
> > >> +	}
> > Okay, I will check it.
> > Thanks for your review!

Also I think that you should apply this Arnd's patch:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?=
id=3D44f6b40c225eb8e82eba8fd96d8f3fb843bc5a09

And maybe it is a good idea to look at applied staging patches:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/driv=
ers/staging/exfat

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--63ohlbp4gwxokjqp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXg+JkgAKCRCL8Mk9A+RD
UoXhAJ44sgetNSzA0PmrQ5zCQYF4kic2tgCeMUINsv0Qdf4DuBROUPpVgpCE+JQ=
=hZkV
-----END PGP SIGNATURE-----

--63ohlbp4gwxokjqp--