Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp18953810ybl; Fri, 3 Jan 2020 12:28:57 -0800 (PST) X-Google-Smtp-Source: APXvYqzORBGsdOJjmcw/P99Zk1Zil/c/tQpkmQX+eE0rwoLMt3K0Xy/oJ230Ip32oe3mdpzYEIXd X-Received: by 2002:a05:6830:4d9:: with SMTP id s25mr100537165otd.171.1578083337509; Fri, 03 Jan 2020 12:28:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578083337; cv=none; d=google.com; s=arc-20160816; b=qiDhnQgQJin9JjvonjxFfTHB5fWkgVXQ3eczGJCtVtXeZYeA3mEurpf261WDG3XDNa En4A/PTSf6ge8t7K+ZmZ2+kAubKztUejboNNPQjwX7OHoxiAf2NfCD51WP15RB6oeT0j yt/8QsV2sATBoIjbREjdmRPPtUF/2vu4qLJbWSbaknQiiWRlUVG4IcTFC9TZWsSYoWMm UI4rOE0ga8yxjM4k3VxmLrAjJFgqbzIwh3BMT5nPsOgfand/c/ulxITGkZwLHClgCcyL eUmoK8Kg2lRNeLJRARQSp+Nn0vERl4bfJS4XV9uafIhSJTNtzuL76eDR2YH6W7MSeEPY eiPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=fGqIhmCppctjLUBxCWzrAERguPHpW/FgjPIK6P8Dd4E=; b=TNU8Amb9OIf3g8HoBeuLOmEi0ID7HILF4bR+aWTiO9Mqg8/rDgj60QoXHZWtP54FGu E28Lbu06c/iXD3TQrRaDRRPAV19p8MG2VOq4uWmIwJW3LW0P0fW9aC0WFSWU9AQbzkSw xtUZF0rtipVA6mewqK9dQjyJBZD7PK/z8QPKWb5yBNnv2s9FwS5zuUHKKOsXYiP04jBs zKSlNsAvErWpt8qpKl4qbclQyst/03Z829v9KYcgfFpuXoJ7ElOzRahyk1yshzpreoi4 hxZo+i0faXzXN6yZIrdmq1krvqT1pXsIbKyoPBaWf+ekhoYV1Te8rqFiX54capVlBBRk P4SA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w24si26075975oic.260.2020.01.03.12.28.45; Fri, 03 Jan 2020 12:28:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728656AbgACU0x (ORCPT + 99 others); Fri, 3 Jan 2020 15:26:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46680 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbgACU0q (ORCPT ); Fri, 3 Jan 2020 15:26:46 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5FB081597661D; Fri, 3 Jan 2020 12:26:46 -0800 (PST) Date: Fri, 03 Jan 2020 12:26:46 -0800 (PST) Message-Id: <20200103.122646.551144444195211447.davem@davemloft.net> To: vulab@iscas.ac.cn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] l2tp: Remove redundant BUG_ON() check in l2tp_pernet From: David Miller In-Reply-To: <1578043696-35911-1-git-send-email-vulab@iscas.ac.cn> References: <1578043696-35911-1-git-send-email-vulab@iscas.ac.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 03 Jan 2020 12:26:46 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xu Wang Date: Fri, 3 Jan 2020 09:28:16 +0000 > Passing NULL to l2tp_pernet causes a crash via BUG_ON. > Dereferencing net in net_generic() also has the same effect. > This patch removes the redundant BUG_ON check on the same parameter. > > Signed-off-by: Xu Wang Applied.