Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Jan 2020 16:14:23 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@sifive.com>
To:     Zong Li <zong.li@sifive.com>
cc:     palmer@dabbelt.com, rostedt@goodmis.org, anup@brainfault.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/2] riscv: ftrace: correct the condition logic in function
 graph tracer
In-Reply-To: <20191223084614.67126-2-zong.li@sifive.com>
Message-ID: <alpine.DEB.2.21.9999.2001031613340.283180@viisi.sifive.com>
References: <20191223084614.67126-1-zong.li@sifive.com> <20191223084614.67126-2-zong.li@sifive.com>
User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 23 Dec 2019, Zong Li wrote:

> The condition should be logical NOT to assign the hook address to parent
> address. Because the return value 0 of function_graph_enter upon
> success.
> 
> Fixes: e949b6db51dc (riscv/function_graph: Simplify with function_graph_enter())
> 

There shouldn't be a blank line here - I've removed it in the queued 
version.

> Signed-off-by: Zong Li <zong.li@sifive.com>

Thanks, queued for v5.5-rc.


- Paul