Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp19122586ybl; Fri, 3 Jan 2020 16:23:13 -0800 (PST) X-Google-Smtp-Source: APXvYqxxPQUPcJFKWYwVNcSkW5VOP6UfV8QapuzpBXydATO866VIG33Rh5qGm7v+rbCPaUP8HeXV X-Received: by 2002:a9d:6f82:: with SMTP id h2mr101496538otq.69.1578097393153; Fri, 03 Jan 2020 16:23:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578097393; cv=none; d=google.com; s=arc-20160816; b=vk1xyHiUNjL/7uwuvZHkeZWd6TpgU9JWg5lumGr0XeWIkQmg3/jhnvS/Qu41Uhhciw jWvT9TdHHU/zjF3LPNZBrTIPCzisHr+PMeJFQwx90ITe1YdwdChgOxk6ODs+LM+O5vsu 4zMkfRYjb1ofqzV4lrBEkng0dH6qQRnmnMuC+wu7KJL/mhZUdcutIjTI2usAeitYPsq2 e0MV1f+JuZVStwET5OyAO0Dd06+YRn9KW9m576YLCw7qpOmffuugalkdTuIRKzDzdBns fqhTJqx+QtfPjkRB8GifphudLEwPKLfnsP/VI+tx7bKOdthb5RSzcHjYP9zcItfmNPbL rDuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=GRrMCIevFS+50QdWWWGaYeUVyp1OjoJAsbXHKCUBzfs=; b=iQhXV+FKFhZXUlks6rjdkqY0dz4QLeKgdknPN7VgWrTCGsLKmQKKvFSynbION3GCip Vi5dmFT7V8A96S0w+gEP4/jJXtLIBX1/F5m4x/94b0PxRxQ4O62emz5Z3DnfKoruCSgd o+tWH/YYnRQ8rRSYE3N7uFNfBG2XX0DMAyXQxDVwMp2V1loAbezaaUuHPeq/td9c/waa U0mZhzkN2+gU8JTwSETyTCrs8uKhvUK+BGeaMAgDRAyR0rA4Cfr6TbwxvH47wbPdnNLg F18FS2zPuF7sx/WEi7DXTqRktoEEKMzqiWO7SZBv5OTbAlSsGmNgljYpnvFNRXzejeLR BrjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d188si25200413oib.273.2020.01.03.16.23.01; Fri, 03 Jan 2020 16:23:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbgADAV4 (ORCPT + 99 others); Fri, 3 Jan 2020 19:21:56 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:41749 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbgADAVz (ORCPT ); Fri, 3 Jan 2020 19:21:55 -0500 Received: by mail-io1-f65.google.com with SMTP id c16so39528357ioo.8 for ; Fri, 03 Jan 2020 16:21:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GRrMCIevFS+50QdWWWGaYeUVyp1OjoJAsbXHKCUBzfs=; b=OGnFrei8QNSAKn4FULWbcecbNt0gWyxIdDhXMh8gGSr9TB7F3lmfjLE34sXTLnmC+G XEA5WmUvrvXlEPHZDJVFdVjBQB+IZ7qsrcOMJpOOd9T2BtFU9w6auloRmwm+x2Y8wkvG nGoPsVRKudGpqrxwZ2iEhxxuR+lnlRxIlNe68BlofsdBBCElXymdXLR7mqFOvleo8BAG 3Ot1KmKkxK4WEC12eR08DbHDRn/LdJYMQxY1S35tNSf9YADh/28arx/maGnwm1VFkcnv GZ7Vb22H0k6WlTCDI+DCbgnG0whHbREymkIAWpWr5VvUJnnIa04hTZ4cLrchNwkW/RC5 NNKw== X-Gm-Message-State: APjAAAWktAdsdV4pR/p3Z6+IlItqIV7p34lxDbqxhwoTVA1QObhpdAfk 8mbE5xb1hvGQw95G+ayYYu4/d5I= X-Received: by 2002:a5e:c014:: with SMTP id u20mr57686242iol.43.1578097314238; Fri, 03 Jan 2020 16:21:54 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id o10sm13764874iob.44.2020.01.03.16.21.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 16:21:53 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 17:21:52 -0700 Date: Fri, 3 Jan 2020 17:21:52 -0700 From: Rob Herring To: Remi Pommarel Cc: Kishon Vijay Abraham I , Yue Wang , Lorenzo Pieralisi , Andrew Murray , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 4/5] dt-bindings: PCI: meson: Update PCIE bindings documentation Message-ID: <20200104002152.GA32487@bogus> References: <20191224173942.18160-1-repk@triplefau.lt> <20191224173942.18160-5-repk@triplefau.lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191224173942.18160-5-repk@triplefau.lt> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 24, 2019 at 06:39:41PM +0100, Remi Pommarel wrote: > Now that a new PHYs has been introduced for AXG SoC family, update > dt bindings documentation. This breaks compatibility. If that's okay, say so and why it is. If only someone had said putting the phy here in the first place was wrong: https://lore.kernel.org/linux-amlogic/20180829004122.GA25928@bogus/ > > Signed-off-by: Remi Pommarel > --- > .../bindings/pci/amlogic,meson-pcie.txt | 22 ++++++++----------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt b/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt > index 84fdc422792e..b6acbe694ffb 100644 > --- a/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt > @@ -18,7 +18,6 @@ Required properties: > - reg-names: Must be > - "elbi" External local bus interface registers > - "cfg" Meson specific registers > - - "phy" Meson PCIE PHY registers for AXG SoC Family > - "config" PCIe configuration space > - reset-gpios: The GPIO to generate PCIe PERST# assert and deassert signal. > - clocks: Must contain an entry for each entry in clock-names. > @@ -26,13 +25,13 @@ Required properties: > - "pclk" PCIe GEN 100M PLL clock > - "port" PCIe_x(A or B) RC clock gate > - "general" PCIe Phy clock > - - "mipi" PCIe_x(A or B) 100M ref clock gate for AXG SoC Family > - resets: phandle to the reset lines. > -- reset-names: must contain "phy" "port" and "apb" > - - "phy" Share PHY reset for AXG SoC Family > +- reset-names: must contain "port" and "apb" > - "port" Port A or B reset > - "apb" Share APB reset > -- phys: should contain a phandle to the shared phy for G12A SoC Family > +- phys: should contain a phandle to the PCIE phy > +- phy-names: must contain "pcie" > + > - device_type: > should be "pci". As specified in designware-pcie.txt > > @@ -43,9 +42,8 @@ Example configuration: > compatible = "amlogic,axg-pcie", "snps,dw-pcie"; > reg = <0x0 0xf9800000 0x0 0x400000 > 0x0 0xff646000 0x0 0x2000 > - 0x0 0xff644000 0x0 0x2000 > 0x0 0xf9f00000 0x0 0x100000>; > - reg-names = "elbi", "cfg", "phy", "config"; > + reg-names = "elbi", "cfg", "config"; > reset-gpios = <&gpio GPIOX_19 GPIO_ACTIVE_HIGH>; > interrupts = ; > #interrupt-cells = <1>; > @@ -58,17 +56,15 @@ Example configuration: > ranges = <0x82000000 0 0 0x0 0xf9c00000 0 0x00300000>; > > clocks = <&clkc CLKID_USB > - &clkc CLKID_MIPI_ENABLE > &clkc CLKID_PCIE_A > &clkc CLKID_PCIE_CML_EN0>; > clock-names = "general", > - "mipi", > "pclk", > "port"; > - resets = <&reset RESET_PCIE_PHY>, > - <&reset RESET_PCIE_A>, > + resets = <&reset RESET_PCIE_A>, > <&reset RESET_PCIE_APB>; > - reset-names = "phy", > - "port", > + reset-names = "port", > "apb"; > + phys = <&pcie_phy>; > + phy-names = "pcie"; > }; > -- > 2.24.0 >