Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp19614871ybl; Sat, 4 Jan 2020 05:22:45 -0800 (PST) X-Google-Smtp-Source: APXvYqw5UyfrCOCtib1gvByfpnWJ3HHrh1Amlm46K8HXDaCaDbPWf2I5F+Zvjh2HDEe3/QFUwh8A X-Received: by 2002:a9d:4d86:: with SMTP id u6mr79865003otk.42.1578144164933; Sat, 04 Jan 2020 05:22:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578144164; cv=none; d=google.com; s=arc-20160816; b=GjHYQ8BKaYpPAmfPoW6sAwfNEhYUSDVa2C7VSy5pnlxrgf44th8OB8B9ls5nNKTyJp C6gijCVRwYF8RvfzeCo2+FM8hTDeKeBzD22pE6mtKL9V7IBUwV6gCnslfPFFEH7JkiXn HeW4oxPiLs52sb/rzz/09KuZX9dIwWbzhgQutFLFOayMO5x+ZRCyxYF4Jpd7m85QCXGo Ea4MSAE30z0Ogr0LWoEeE3Jpy1CE46sLgA5LrG5D/m0Oh7cpF+/Gayea0nqNXIkunV7K MyVoyl2I1pIMENaN/fuGq5HvR+Ikk6B/L914iaSXdVVaBYbiOv+AjRFNOipcRLudi5gL 1ceg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:message-id:date :subject:cc:to:from; bh=IwC/Z/pVt5gX6RA0zJHiBD+37iQZcELVyjjHnKvvPy4=; b=NSONjX0jumhkb1XM5orx0ohhB78e93/7ofB13VS6Q2Mb4VJSjo+mQ9/JnENeBqp0ei ZwQvdo4m4qhmNVki6kfv72WreND4N4XmZmJ5czCBdpk0ou1yljSIxvBEPHeCk1v8Vook Rsba8naCIj5vFq303jVTHSby/rLxT7ttQdgiEiEzP9Y/RSIGWWPC/IeS3dMpLMvuMI4x E4khN8XIGphtttcaqIGxavwDZCcwSjOUUj262L+9Ymoy6YZ7TVxtvA0s06UIavRRppQF NpyZZHENxHi8qB8TX2tfs+CjD1edlng8cF1VHRrZpkKAUlECRM6bxAa/SpbgalRQykd1 qEEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=puri.sm Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30si20719888otr.75.2020.01.04.05.22.19; Sat, 04 Jan 2020 05:22:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=puri.sm Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726005AbgADNVG (ORCPT + 99 others); Sat, 4 Jan 2020 08:21:06 -0500 Received: from comms.puri.sm ([159.203.221.185]:46510 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgADNVG (ORCPT ); Sat, 4 Jan 2020 08:21:06 -0500 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id DA395E035E; Sat, 4 Jan 2020 05:21:04 -0800 (PST) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vKecNyt8erw3; Sat, 4 Jan 2020 05:21:03 -0800 (PST) From: Martin Kepplinger To: lorenzo.bianconi83@gmail.com, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH v2] iio: imu: st_lsm6dsx: add mount matrix support Date: Sat, 4 Jan 2020 14:20:52 +0100 Message-Id: <20200104132052.28337-1-martin.kepplinger@puri.sm> Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allow to read the mount-matrix device tree property and provide the mount_matrix file for userspace to read. Signed-off-by: Martin Kepplinger --- tested using the lsm9ds1 on the librem5-devkit (and userspace tools like iio-sensor-proxy) where this will be needed. thanks, martin revision history ---------------- v2: additions and simplifications according to Lorenzo's review. thanks. drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 19 +++++++++++++++++++ drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h index a763ff46f596..7076fc8c4c3b 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -76,6 +76,7 @@ enum st_lsm6dsx_hw_id { .endianness = IIO_LE, \ }, \ .event_spec = &st_lsm6dsx_event, \ + .ext_info = st_lsm6dsx_accel_ext_info, \ .num_event_specs = 1, \ } @@ -380,6 +381,7 @@ struct st_lsm6dsx_sensor { * @enable_event: enabled event bitmask. * @iio_devs: Pointers to acc/gyro iio_dev instances. * @settings: Pointer to the specific sensor settings in use. + * @orientation: sensor chip orientation relative to main hardware. */ struct st_lsm6dsx_hw { struct device *dev; @@ -406,6 +408,8 @@ struct st_lsm6dsx_hw { struct iio_dev *iio_devs[ST_LSM6DSX_ID_MAX]; const struct st_lsm6dsx_settings *settings; + + struct iio_mount_matrix orientation; }; static __maybe_unused const struct iio_event_spec st_lsm6dsx_event = { @@ -479,4 +483,19 @@ st_lsm6dsx_write_locked(struct st_lsm6dsx_hw *hw, unsigned int addr, return err; } +static const inline struct iio_mount_matrix * +st_lsm6dsx_get_mount_matrix(const struct iio_dev *iio_dev, + const struct iio_chan_spec *chan) +{ + struct st_lsm6dsx_sensor *sensor = iio_priv(iio_dev); + struct st_lsm6dsx_hw *hw = sensor->hw; + + return &hw->orientation; +} + +static const struct iio_chan_spec_ext_info st_lsm6dsx_accel_ext_info[] = { + IIO_MOUNT_MATRIX(IIO_SHARED_BY_ALL, st_lsm6dsx_get_mount_matrix), + { } +}; + #endif /* ST_LSM6DSX_H */ diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index 0c64e35c7599..27e157f8a031 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -2325,7 +2325,7 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id, (pdata && pdata->wakeup_source)) device_init_wakeup(dev, true); - return 0; + return iio_read_mount_matrix(hw->dev, "mount-matrix", &hw->orientation); } EXPORT_SYMBOL(st_lsm6dsx_probe); -- 2.20.1