Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: +iLJQ4KnATKypVW/wfC3iSAgCTY01+LcENEAqn0Vsq0u642MOusIXsbdfo67PcJPvzjgyk63U3
 e3690yuqvKmeDYf6L3Kpcd+JsvEYfVNhsEZYAcpHh8thgzVhM1B02AALeOd0gcYtdaaTe7gGAJ
 YYzQ9z0VZUeQRsodk+6Ap6tzyxSS7kduo99QPjAm6+7o9cX5wY0Vq3b+/tytxkXfxxHLFp2A2w
 hrGMYEEsRI8lIMomS3AWceQqeWDmcPYnfBsTX5mEIBBsSgn4Q0jNY8QWy4+bpPEvPhZFV9mar7
 RiI=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Balbir Singh <sblbir@amazon.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
CC:     "axboe@kernel.dk" <axboe@kernel.dk>,
        "ssomesh@amazon.com" <ssomesh@amazon.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "hch@lst.de" <hch@lst.de>, "mst@redhat.com" <mst@redhat.com>
Subject: Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use
 disk_set_capacity
Thread-Topic: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use
 disk_set_capacity
Thread-Index: AQHVwUHMcV4G7Nsdi0W8ganO7VoHBg==
Date:   Sat, 4 Jan 2020 22:27:39 +0000
Message-ID: <BYAPR04MB57490FFCC025A88F4D97D40A86220@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20200102075315.22652-1-sblbir@amazon.com>
 <20200102075315.22652-5-sblbir@amazon.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c6f5ad70-ca49-4468-f9db-08d791654f02
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2020 22:27:39.6905
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JXlLn7L45wsIed3TqlYX5yI9pf/FcuSJ3Y/S+9vfDiHyL3Gi5b2Al4niHugcFxudr0lGGbI33Sbez1m5938y/R6qOI+XOSKqcd2mGlqxBjA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4904
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quick question here if user executes nvme ns-rescan /dev/nvme1=0A=
will following code result in triggering uevent(s) for=0A=
the namespace(s( for which there is no change in the size ?=0A=
=0A=
If so is that an expected behavior ?=0A=
=0A=
On 01/01/2020 11:54 PM, Balbir Singh wrote:=0A=
> block/genhd provides disk_set_capacity() for sending=0A=
> RESIZE notifications via uevents. This notification is=0A=
> newly added to NVME devices=0A=
>=0A=
> Signed-off-by: Balbir Singh <sblbir@amazon.com>=0A=
> ---=0A=
>   drivers/nvme/host/core.c | 2 +-=0A=
>   1 file changed, 1 insertion(+), 1 deletion(-)=0A=
>=0A=
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c=0A=
> index 667f18f465be..cb214e914fc2 100644=0A=
> --- a/drivers/nvme/host/core.c=0A=
> +++ b/drivers/nvme/host/core.c=0A=
> @@ -1808,7 +1808,7 @@ static void nvme_update_disk_info(struct gendisk *d=
isk,=0A=
>   	    ns->lba_shift > PAGE_SHIFT)=0A=
>   		capacity =3D 0;=0A=
>=0A=
> -	set_capacity(disk, capacity);=0A=
> +	disk_set_capacity(disk, capacity);=0A=
>=0A=
>   	nvme_config_discard(disk, ns);=0A=
>   	nvme_config_write_zeroes(disk, ns);=0A=
>=0A=
=0A=