Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp20889703ybl; Sun, 5 Jan 2020 14:09:37 -0800 (PST) X-Google-Smtp-Source: APXvYqw8W0eaM73lJB/5L1dPeokXRc70HSO5Klu8PLfVnfbtP52dX8VzCn9ydQXxBId0jfKcPJ7/ X-Received: by 2002:a9d:6301:: with SMTP id q1mr6468579otk.70.1578262177577; Sun, 05 Jan 2020 14:09:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578262177; cv=none; d=google.com; s=arc-20160816; b=sMfuj2mMVzws7iF9mcclEbavaMwVs/fY4OkbKBcJvpx2w7t53r5RE1KwFoQl1Yqik2 W4vaEbTEcPufURK7xPmq6cQkZ9G2JgqcHEKV4iR8Hdc0c5q2rOnQeAzKyWdwb6wPSh7Y 6GX2Hbt5XUgp4Nnw2nbu9w1mcbEKWw+inMesGqSDlNhm/jqqB9FnDGb2tuR3ubjoIdQU kCKfjRkgSX8tQnIsLGUZj+MYY3ouV8MAyzPkT3lzHwxbDg2pWtjY42sa/JNmxmPPq6f7 fm+/5+SW5bo4tQZdGh5gyIGQGOxKzygouOqZUnzUQNPXSHu9CMkenT528ZThPLKySGQR EKNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=gN32nj0fCJV1JTpdvkxbljfmBSVYN/OI2ByyfTw0WlA=; b=TktHa9sGCdvzr2Ti5xG9A0cBiZubaeMvf8R2LiGQulvUnajVVoQsL6HJq/PLKsKkvy fAFWC29wKv/BbRaBZQVixu69dbW249czMuS21aaHXwzxmlP0ylFroeAMoyYhgJNUS+jh bUWRlIIU03xT9g+M12IVSUMvyas8leoryZBp0ysYGEuNV+a+Gl6rKzFktawMUSW9L2TQ l+7BlZ6Hk9qp4wmfsYAijjXvoC54WktfbRddWgoLqUNnd2g8sEoTEXnAykTzOsEAA+U5 QHG4ZmcoOC8x7Oblmp4ydkh6dTEaz/ehEHvzdX/MJvO9oTIXv+pRbRLLA3PrJYdtEZgz vV9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="DH/djuKM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 128si25763994oih.78.2020.01.05.14.09.25; Sun, 05 Jan 2020 14:09:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="DH/djuKM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbgAEWIN (ORCPT + 99 others); Sun, 5 Jan 2020 17:08:13 -0500 Received: from mail-ua1-f66.google.com ([209.85.222.66]:33245 "EHLO mail-ua1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbgAEWIN (ORCPT ); Sun, 5 Jan 2020 17:08:13 -0500 Received: by mail-ua1-f66.google.com with SMTP id a12so16481113uan.0 for ; Sun, 05 Jan 2020 14:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gN32nj0fCJV1JTpdvkxbljfmBSVYN/OI2ByyfTw0WlA=; b=DH/djuKMsWL5Ji9Mluc7+DUJAPlPGwfTWrEJA06R1Gl4RMN200Cvg4hxzeiLl27fJ6 7+V6vdsKgEeisXdUU4plTEPrbTYyy5/KrVeSfrjXWra9+2Hm8T4rxOJHrVRpFFBC/iG5 uw6b6pflkhHdnMX/7hPUT9c/YEY0mm4JSf1w/vZ4vTT9tT+i63PeQf6CEXMtEp582ybR VbVZEVzvCvmFSjI7XzsFa0rSFL04ZbjmefKfEjGDaGNA8ZRxnKRofPlIs4M+Pi2OMSjC n/VAaw/3DOvNeKbDPHGZ8IASRk/F3s4Hs/YRKWmZ6dtc6NkYxpZsphMuvupJHSQ5R0r5 C9ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gN32nj0fCJV1JTpdvkxbljfmBSVYN/OI2ByyfTw0WlA=; b=f9D/fC6aa4nfaaytww5IoUbyTu49bHio++3q+TIsIom4AeoSo0ztAMUtcX/I2ljgls KP8wSeo4GInf5cjp+mjAo4oiBqe5nG4uiRpaae+f8qtRErqzBHyDM4luhTP7ooTUm44N VXOp8GUw4WX0pHFOtsOsV23yuz1HXS1DVxJshQgScC47/RstUkwU5spocJ+0YmRZHbzV yR836vbtjIBpx8/QwU/m/ndiDDKmbv/Sw7YD5d4cdtOWRZGsgkordEgBaa/7vPithLwK cfq5Cksh7wOaFqPebBwNZHMdxQBo4ACfRt6D6qVOMz0yPPua0SU5d6HIoiP6mLOORdxS xHpA== X-Gm-Message-State: APjAAAWtNdwGyLrnX3ryX2B843NhNudFc1oEz+XMZNDal+ilwY156+OE GoolwiZIykgHBLnVKgPoNdO5h2hqwb8EcEeQ0LE= X-Received: by 2002:ab0:72d0:: with SMTP id g16mr55270503uap.11.1578262092346; Sun, 05 Jan 2020 14:08:12 -0800 (PST) MIME-Version: 1.0 References: <20191231205734.1452-1-wambui.karugax@gmail.com> <20200101185147.GB3856@dvetter-linux.ger.corp.intel.com> In-Reply-To: <20200101185147.GB3856@dvetter-linux.ger.corp.intel.com> From: Ben Skeggs Date: Mon, 6 Jan 2020 08:08:01 +1000 Message-ID: Subject: Re: [Nouveau] [PATCH] drm/nouveau: use NULL for pointer assignment. To: Wambui Karuga , Ben Skeggs , Dave Airlie , ML dri-devel , ML nouveau , LKML Cc: Daniel Vetter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Jan 2020 at 04:51, Daniel Vetter wrote: > > On Tue, Dec 31, 2019 at 11:57:34PM +0300, Wambui Karuga wrote: > > Replace the use of 0 in the pointer assignment with NULL to address the > > following sparse warning: > > drivers/gpu/drm/nouveau/nouveau_hwmon.c:744:29: warning: Using plain integer as NULL pointer > > > > Signed-off-by: Wambui Karuga > > Reviewed-by: Daniel Vetter > > I'll check with Ben next week or so whether he wants to pick these up or > whether I should stuff them into drm-misc-next. I'll grab them. Ben. > -Daniel > > > --- > > drivers/gpu/drm/nouveau/nouveau_hwmon.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > > index d445c6f3fece..1c3104d20571 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > > @@ -741,7 +741,7 @@ nouveau_hwmon_init(struct drm_device *dev) > > special_groups[i++] = &pwm_fan_sensor_group; > > } > > > > - special_groups[i] = 0; > > + special_groups[i] = NULL; > > hwmon_dev = hwmon_device_register_with_info(dev->dev, "nouveau", dev, > > &nouveau_chip_info, > > special_groups); > > -- > > 2.17.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau