Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200104194334.12237-1-info@metux.net>
In-Reply-To: <20200104194334.12237-1-info@metux.net>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Mon, 6 Jan 2020 10:39:39 +0100
Message-ID: <CAMpxmJXSrF6sDQgCGy+j0NiFVN7NTcxNC9Et4KZxvNbOXRd01w@mail.gmail.com>
Subject: Re: [PATCH] gpio: gpiolib: fix confusing indention
To:     "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

sob., 4 sty 2020 o 20:49 Enrico Weigelt, metux IT consult
<info@metux.net> napisa=C5=82(a):
>
> There's a confusing indention in gpiochip_add_data_with_key(), which
> could be misinterpreted on a quick walkthrough. Fixing this in order
> to improve code readability a bit.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 3fa2f4d3cdce..d77695cc82ef 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1447,7 +1447,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *ch=
ip, void *data,
>
>         if (chip->ngpio > FASTPATH_NGPIO)
>                 chip_warn(chip, "line cnt %u is greater than fast path cn=
t %u\n",
> -               chip->ngpio, FASTPATH_NGPIO);
> +                         chip->ngpio, FASTPATH_NGPIO);
>
>         gdev->label =3D kstrdup_const(chip->label ?: "unknown", GFP_KERNE=
L);
>         if (!gdev->label) {
> --
> 2.11.0
>

Patch applied, thanks!

Bart