Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
To:     =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>
CC:     "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: imu/mpu6050: support dual-edge IRQ
Thread-Topic: [PATCH] iio: imu/mpu6050: support dual-edge IRQ
Thread-Index: AQHVwx5GRqw8i2TNS0SP7XRwRJJyD6fdY4sb
Date:   Mon, 6 Jan 2020 09:42:00 +0000
Message-ID: <MN2PR12MB33737F067F25B2F7477C4FE5C43C0@MN2PR12MB3373.namprd12.prod.outlook.com>
References: <e03daea84ce5fe5e79311a07fee4636c2a884a8e.1578156240.git.mirq-linux@rere.qmqm.pl>
In-Reply-To: <e03daea84ce5fe5e79311a07fee4636c2a884a8e.1578156240.git.mirq-linux@rere.qmqm.pl>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: invensense.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b0bf2780-3fb3-4a50-9253-08d7928cadcd
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2020 09:42:00.1933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 462b3b3b-e42b-47ea-801a-f1581aac892d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: V2iz+n1iZciwCDLpip0uPe67wxxugp3ebptwmCRIKoVqWsyESg0xHyfCbQ+ehnQSNmmo73430En69aAEkppMNiT7HQS0pVxi1oIb5QSAU/s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4192
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572
 definitions=2020-01-06_02:2020-01-06,2020-01-06 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 mlxlogscore=999 clxscore=1011 priorityscore=1501 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1910280000 definitions=main-2001060088
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Michal,=0A=
=0A=
interesting, thanks a lot.=0A=
=0A=
It would be far better to simply delete the warning log for spurious interr=
upt. I was thinking that it would only be triggered by a real bug somewhere=
. I wasn't thinking about systems with any-edge trigger like yours.=0A=
=0A=
So just delete the warn message and no need to add the irq_ignore_spurious =
logic and variable.=0A=
=0A=
Thanks,=0A=
JB=0A=
=0A=
From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> on =
behalf of Micha=B3 Miros=B3aw <mirq-linux@rere.qmqm.pl>=0A=
=0A=
Sent: Saturday, January 4, 2020 17:44=0A=
=0A=
To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; =
Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw=
.net>=0A=
=0A=
Cc: linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; linux-kernel@vge=
r.kernel.org <linux-kernel@vger.kernel.org>=0A=
=0A=
Subject: [PATCH] iio: imu/mpu6050: support dual-edge IRQ=0A=
=0A=
=A0=0A=
=0A=
=0A=
=A0CAUTION: This email originated from outside of the organization. Please =
make sure the sender is who they say they are and do not click links or ope=
n attachments unless you recognize the sender and know the content is safe.=
=0A=
=0A=
=0A=
=0A=
Make mpu6050 usable on platforms which provide only any-edge interrupts.=0A=
=0A=
=0A=
=0A=
Signed-off-by: Micha=B3 Miros=B3aw <mirq-linux@rere.qmqm.pl>=0A=
=0A=
---=0A=
=0A=
=A0drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 3 ++-=0A=
=0A=
=A0drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h=A0 | 1 +=0A=
=0A=
=A0drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 6 ++++--=0A=
=0A=
=A03 files changed, 7 insertions(+), 3 deletions(-)=0A=
=0A=
=0A=
=0A=
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/i=
nv_mpu6050/inv_mpu_core.c=0A=
=0A=
index 0686e41bb8a1..36b6a3922d15 100644=0A=
=0A=
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c=0A=
=0A=
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c=0A=
=0A=
@@ -1239,9 +1239,10 @@ int inv_mpu_core_probe(struct regmap *regmap, int ir=
q, const char *name,=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 }=0A=
=0A=
=A0=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 irq_type =3D irqd_get_trigger_type(desc);=0A=
=0A=
+=A0=A0=A0=A0=A0=A0 st->irq_ignore_spurious =3D irq_type =3D=3D (IRQF_TRIGG=
ER_RISING|IRQF_TRIGGER_FALLING);=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 if (!irq_type)=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 irq_type =3D IRQF_TRIGGER_=
RISING;=0A=
=0A=
-=A0=A0=A0=A0=A0=A0 if (irq_type =3D=3D IRQF_TRIGGER_RISING)=0A=
=0A=
+=A0=A0=A0=A0=A0=A0 if (irq_type =3D=3D IRQF_TRIGGER_RISING || st->irq_igno=
re_spurious)=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 st->irq_mask =3D INV_MPU60=
50_ACTIVE_HIGH;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 else if (irq_type =3D=3D IRQF_TRIGGER_FALLING)=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 st->irq_mask =3D INV_MPU60=
50_ACTIVE_LOW;=0A=
=0A=
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/in=
v_mpu6050/inv_mpu_iio.h=0A=
=0A=
index b096e010d4ee..94ee7b18b198 100644=0A=
=0A=
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h=0A=
=0A=
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h=0A=
=0A=
@@ -158,6 +158,7 @@ struct inv_mpu6050_state {=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 struct regmap *map;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 int irq;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 u8 irq_mask;=0A=
=0A=
+=A0=A0=A0=A0=A0=A0 u8 irq_ignore_spurious;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 unsigned skip_samples;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 s64 chip_period;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 s64 it_timestamp;=0A=
=0A=
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c b/drivers/iio/imu/i=
nv_mpu6050/inv_mpu_ring.c=0A=
=0A=
index 10d16ec5104b..52f02de3d9b0 100644=0A=
=0A=
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c=0A=
=0A=
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c=0A=
=0A=
@@ -184,8 +184,10 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 goto flush_fifo;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 }=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 if (!(int_status & INV_MPU6050_BIT_RAW_DATA_RDY_IN=
T)) {=0A=
=0A=
-=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 dev_warn(regmap_get_device(st->=
map),=0A=
=0A=
-=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 "spurio=
us interrupt with status 0x%x\n", int_status);=0A=
=0A=
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (!st->irq_ignore_spurious)=
=0A=
=0A=
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 dev_war=
n(regmap_get_device(st->map),=0A=
=0A=
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 "spurious interrupt with status 0x%x\n",=0A=
=0A=
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0 int_status);=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 goto end_session;=0A=
=0A=
=A0=A0=A0=A0=A0=A0=A0=A0 }=0A=
=0A=
=A0=0A=
=0A=
-- =0A=
=0A=
2.20.1=0A=
=0A=
=0A=
=0A=