Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200103114400.17668-1-rocking@linux.alibaba.com>
In-Reply-To: <20200103114400.17668-1-rocking@linux.alibaba.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Mon, 6 Jan 2020 14:34:28 +0100
Message-ID: <CAKfTPtAYHqbbVkQdT3A6qgbehZr8Yxa-bFjOXG7oG7eaN=uckA@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: calculate delta runnable load only when it's needed
To:     Peng Wang <rocking@linux.alibaba.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 3 Jan 2020 at 12:45, Peng Wang <rocking@linux.alibaba.com> wrote:
>
> Move the code of calculation for delta_sum/delta_avg to where

Maybe precise that you move delta_sum/delta_avg for runnable_load_sum/avg

> it is really needed to be done.
>
> Signed-off-by: Peng Wang <rocking@linux.alibaba.com>

make sense to me

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  kernel/sched/fair.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index ba749f579714..6b7e6b528e9b 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3366,16 +3366,17 @@ update_tg_cfs_runnable(struct cfs_rq *cfs_rq, struct sched_entity *se, struct cf
>
>         runnable_load_sum = (s64)se_runnable(se) * runnable_sum;
>         runnable_load_avg = div_s64(runnable_load_sum, LOAD_AVG_MAX);
> -       delta_sum = runnable_load_sum - se_weight(se) * se->avg.runnable_load_sum;
> -       delta_avg = runnable_load_avg - se->avg.runnable_load_avg;
> -
> -       se->avg.runnable_load_sum = runnable_sum;
> -       se->avg.runnable_load_avg = runnable_load_avg;
>
>         if (se->on_rq) {
> +               delta_sum = runnable_load_sum -
> +                               se_weight(se) * se->avg.runnable_load_sum;
> +               delta_avg = runnable_load_avg - se->avg.runnable_load_avg;
>                 add_positive(&cfs_rq->avg.runnable_load_avg, delta_avg);
>                 add_positive(&cfs_rq->avg.runnable_load_sum, delta_sum);
>         }
> +
> +       se->avg.runnable_load_sum = runnable_sum;
> +       se->avg.runnable_load_avg = runnable_load_avg;
>  }
>
>  static inline void add_tg_cfs_propagate(struct cfs_rq *cfs_rq, long runnable_sum)
> --
> 2.24.0
>