Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1577111958-100981-1-git-send-email-chenwandun@huawei.com>
In-Reply-To: <1577111958-100981-1-git-send-email-chenwandun@huawei.com>
From:   Ilya Dryomov <idryomov@gmail.com>
Date:   Mon, 6 Jan 2020 16:04:36 +0100
Message-ID: <CAOi1vP9-s9rp1=BTHrd=ounkZ0bzYV4HfKao6_GL+r8gh1muhg@mail.gmail.com>
Subject: Re: [PATCH next] ceph: Fix debugfs_simple_attr.cocci warnings
To:     Chen Wandun <chenwandun@huawei.com>
Cc:     Jeff Layton <jlayton@kernel.org>, Sage Weil <sage@redhat.com>,
        Ceph Development <ceph-devel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 23, 2019 at 3:32 PM Chen Wandun <chenwandun@huawei.com> wrote:
>
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> ---
>  fs/ceph/debugfs.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index c281f32..60a0f1a 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -243,8 +243,8 @@ static int congestion_kb_get(void *data, u64 *val)
>         return 0;
>  }
>
> -DEFINE_SIMPLE_ATTRIBUTE(congestion_kb_fops, congestion_kb_get,
> -                       congestion_kb_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(congestion_kb_fops, congestion_kb_get,
> +                        congestion_kb_set, "%llu\n");
>
>
>  void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc)
> @@ -264,11 +264,11 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
>
>         dout("ceph_fs_debugfs_init\n");
>         fsc->debugfs_congestion_kb =
> -               debugfs_create_file("writeback_congestion_kb",
> -                                   0600,
> -                                   fsc->client->debugfs_dir,
> -                                   fsc,
> -                                   &congestion_kb_fops);
> +               debugfs_create_file_unsafe("writeback_congestion_kb",
> +                                          0600,
> +                                          fsc->client->debugfs_dir,
> +                                          fsc,
> +                                          &congestion_kb_fops);

Hi Chen,

debugfs_create_file_unsafe() has "unsafe" in its name for a reason.
Have you verified that this conversion is safe?

Thanks,

                Ilya