Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp21623780ybl; Mon, 6 Jan 2020 08:09:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxQ4ZmxHYi3gydl9qdGU/3r5zS9/30Tzbd2g/MmqsNIfT/WlFGJaQ2KGNANS6h1sOiGU1QD X-Received: by 2002:aca:b187:: with SMTP id a129mr5962675oif.175.1578326963869; Mon, 06 Jan 2020 08:09:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578326963; cv=none; d=google.com; s=arc-20160816; b=xM4R7UKIdTeILF3GBrRSqyvdeX+rXOUIIxvJ+inI6JAmUrXVNRF2nYUuFyppLvNA6I qXtlSn1Yd2JrDoULgjoIPN546OIgaZs9EYK75G009uCvAADzc6nUFcWFTW7ngQoo/V3f RgIBujonXFAvuI4S88H/oHlGWY0qqw4KSCuP/tMaPNtAOmOrBZIC39xwxbCpoeA5MxHJ RZZUt1YuIsmwl5YNB9oUVu/GLjkl5vHBGERHt/HkbtIWjsuoG3emMp9SUvei0j2o6/N2 s3fQSi2vtaJjcO8iBAV+84Doe8WcQx+MqduSVoVkX8ZnOiLi/d3xi9NUHRls0/pkkfn8 /OhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=630boAkSCrcp336402tyfudt+DYnXY0CWTz8qD+Fn9A=; b=G/Juk2bRQo9/7Tcpo5YN7LVISjr447MU0J5cECnEdJAh2zpRekzy0qtls76ezsTuq3 DQ8yHr5UMYO2PYtQtqtnJKSggxu0Eq16THjAhwunKivAtjGgIJIMjbVz8atMahIP2WWI NntBZHWvZRRhRKw/g3yu2sItIIie8Ya9dEia7vQ4kWEIlZ+Rpj+XEFPwJpfM3cyNFGdj KHQQ0Z0sWtaYBo3uzl5IPfhUl3A//Z8f8TsmhWKXB+kxgMVcZ5wsB06Gkh+6pMFLO3cv sIwMXrKwsypZVgjWlLXXfBtx4wQImAqQEGjSgsZcUedvzsEGDq1TNCDspv0TKB7sN6fc p8bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SuMX+3Y5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e192si34289285oib.82.2020.01.06.08.09.12; Mon, 06 Jan 2020 08:09:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SuMX+3Y5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727227AbgAFQIJ (ORCPT + 99 others); Mon, 6 Jan 2020 11:08:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:46458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727219AbgAFQIH (ORCPT ); Mon, 6 Jan 2020 11:08:07 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40C2C2146E; Mon, 6 Jan 2020 16:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578326886; bh=mCA865SAZMIdDCprZ6Kw2vVQILF3FcoPXROi00u1AA0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SuMX+3Y5FTBZNA9lkMYoQSv3lwMAxEkjkVggGatwjvKqeI9fLEKIH0+hcqeLQuDFr ZdEQvW0Ilb0d/+HjGaPXwdmGz0PiNM0FVlLStMnsd7+fNR8goJrZnX5SBf9CrDcHQr 6U3sCbSK4UFPR4XTad7NalADqrlgk9S0b8+gRLrw= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Andi Kleen , Jin Yao , Kan Liang , Linus Torvalds Subject: [PATCH 14/20] perf report/top: Add 'k' hotkey to zoom directly into the kernel map Date: Mon, 6 Jan 2020 13:06:59 -0300 Message-Id: <20200106160705.10899-15-acme@kernel.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200106160705.10899-1-acme@kernel.org> References: <20200106160705.10899-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo As a convenience, equivalent to pressing Enter in a line with a kernel symbol and then selecting "Zoom" into the kernel DSO. Reviewed-by: Jiri Olsa Cc: Adrian Hunter Cc: Andi Kleen Cc: Jin Yao Cc: Kan Liang Cc: Linus Torvalds Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-vbnlnrpyfvz9deqoobtc3dz7@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 8aba1aeea0eb..6dfdd8d5a743 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -18,7 +18,9 @@ #include "../../util/evlist.h" #include "../../util/header.h" #include "../../util/hist.h" +#include "../../util/machine.h" #include "../../util/map.h" +#include "../../util/maps.h" #include "../../util/symbol.h" #include "../../util/map_symbol.h" #include "../../util/branch.h" @@ -2566,7 +2568,7 @@ add_dso_opt(struct hist_browser *browser, struct popup_action *act, if (!hists__has(browser->hists, dso) || map == NULL) return 0; - if (asprintf(optstr, "Zoom %s %s DSO", + if (asprintf(optstr, "Zoom %s %s DSO (use the 'k' hotkey to zoom directly into the kernel)", browser->hists->dso_filter ? "out of" : "into", __map__is_kernel(map) ? "the Kernel" : map->dso->short_name) < 0) return 0; @@ -2936,6 +2938,7 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events, "E Expand all callchains\n" \ "F Toggle percentage of filtered entries\n" \ "H Display column headers\n" \ + "k Zoom into the kernel map\n" \ "L Change percent limit\n" \ "m Display context menu\n" \ "S Zoom into current Processor Socket\n" \ @@ -3033,6 +3036,10 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events, actions->ms.map = map; do_zoom_dso(browser, actions); continue; + case 'k': + if (browser->selection != NULL) + hists_browser__zoom_map(browser, browser->selection->maps->machine->vmlinux_map); + continue; case 'V': verbose = (verbose + 1) % 4; browser->show_dso = verbose > 0; -- 2.21.1