Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp21624412ybl; Mon, 6 Jan 2020 08:10:00 -0800 (PST) X-Google-Smtp-Source: APXvYqx/kqqFao3Hpmqdqh9nXF6v7iYETS2ut19oqrYj6YP64czeOmSInWgIE3fLyPDLTi3E+B9+ X-Received: by 2002:a9d:7dc9:: with SMTP id k9mr115978954otn.117.1578327000151; Mon, 06 Jan 2020 08:10:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578327000; cv=none; d=google.com; s=arc-20160816; b=LqU//S59C1mOlFFT9TQCJMykGxPxQXhBFE4vG0qWmotfcsxCcYq3+cf3RnOed48Xjq G1ASRCjettIDhgTE/y1K33kdPdASpqrzN2AHzU20ptHvzcPYcpiOc2mKX/nJ6FSsJApz 10cZDkhVULuHKFadh+0XwHLyovH3/PB2RfJOPsQAwTbQdX1FpNZhXBoQ+mSQ3AtdHc9Y vFf7zPFFyjDfHQhombTZQdkKjnpawdJjsmcde6VeOWfRtccXSrBdE+NZaKQ37xbdg2kP IixQJN/tYf+dGZhPYLs9NzIASGnAcJkTqlR4umKDDqeW2XX1pJIfZoXivAjEfwC+0bzZ YVcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hp4qtODmWXW0kiAqfX82gkNoxnIWdj/EqbSx6qKIHN8=; b=I12+jHEkkss3JFfj8uXuh+kc+7oalb/0hwGiDWatwJqJFQFkZI4DD5xCeb27JqpjjH 5cBlTmWNwnADFVkgI2jtmtvSPpZqSgTqp4WJuYVBbQoiOfhWm0ri6Xd9v8hj3x56jFNS hnLelZe+qm8c73Zxx06UHj4Eb6tWW4ve+yiAyaJ2hivq3bKTRu768suD44l/BD+orIPE sOWdaI5Z57o0ka5oOxO4wXaTZjT0S6HJqEmdwSyQEQyIYb9metVQmJS3XFSV3q07aWx8 NwTgFPbIBf5RtZZRgTDLFQEeX2JqRAF0B8oV6F+/Ha/2WfSigWJEcl0EWFAAZa8IzsEN SeNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SeTZ6zdo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y186si34163101oig.241.2020.01.06.08.09.47; Mon, 06 Jan 2020 08:10:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SeTZ6zdo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727128AbgAFQHu (ORCPT + 99 others); Mon, 6 Jan 2020 11:07:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:45746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbgAFQHs (ORCPT ); Mon, 6 Jan 2020 11:07:48 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C893224676; Mon, 6 Jan 2020 16:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578326868; bh=FujDq/kHrhJEWeENq9jN+oNiwsQo0/L2lnSlXsVYWsI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SeTZ6zdo8NWw+0AjpqzNpm7Z5ktiVHBn1Yx9Y5gdHGxmmWBWpLa7WI726VKBSWR6J rqeq+0wJv2ao5mWMGZush3BrViRX3Gz99Dp4mrR5TRJYvu+LRO9jLXOP/Ke95jmbt/ /JvdoWhi83pKZWQxDB/N4gH/3MHwgSYaPrNTfbXU= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter Subject: [PATCH 09/20] perf hists browser: Restore ESC as "Zoom out" of DSO/thread/etc Date: Mon, 6 Jan 2020 13:06:54 -0300 Message-Id: <20200106160705.10899-10-acme@kernel.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200106160705.10899-1-acme@kernel.org> References: <20200106160705.10899-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo We need to set actions->ms.map since 599a2f38a989 ("perf hists browser: Check sort keys before hot key actions"), as in that patch we bail out if map is NULL. Reviewed-by: Jiri Olsa Cc: Adrian Hunter Cc: Namhyung Kim Fixes: 599a2f38a989 ("perf hists browser: Check sort keys before hot key actions") Link: https://lkml.kernel.org/n/tip-wp1ssoewy6zihwwexqpohv0j@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index d4d3558fdef4..cfc6172ecab7 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -3062,6 +3062,7 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events, continue; } + actions->ms.map = map; top = pstack__peek(browser->pstack); if (top == &browser->hists->dso_filter) { /* -- 2.21.1