Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 6 Jan 2020 16:33:03 +0000
From:   Mel Gorman <mgorman@techsingularity.net>
To:     Rik van Riel <riel@surriel.com>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, pauld@redhat.com,
        valentin.schneider@arm.com, srikar@linux.vnet.ibm.com,
        quentin.perret@arm.com, dietmar.eggemann@arm.com,
        Morten.Rasmussen@arm.com, hdanton@sina.com, parth@linux.ibm.com,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched, fair: Allow a small load imbalance between low
 utilisation SD_NUMA domains v3
Message-ID: <20200106163303.GC3466@techsingularity.net>
References: <20200106144250.GA3466@techsingularity.net>
 <04033a63f11a9c59ebd2b099355915e4e889b772.camel@surriel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <04033a63f11a9c59ebd2b099355915e4e889b772.camel@surriel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 06, 2020 at 10:47:18AM -0500, Rik van Riel wrote:
> > +			imbalance_adj = (100 / (env->sd->imbalance_pct
> > - 100)) - 1;
> > +
> > +			/*
> > +			 * Allow small imbalances when the busiest
> > group has
> > +			 * low utilisation.
> > +			 */
> > +			imbalance_max = imbalance_adj << 1;
> > +			if (busiest->sum_nr_running < imbalance_max)
> > +				env->imbalance -= min(env->imbalance,
> > imbalance_adj);
> > +		}
> > +
> 
> Wait, so imbalance_max is a function only of
> env->sd->imbalance_pct, and it gets compared
> against busiest->sum_nr_running, which is related
> to the number of CPUs in the node?
> 

It's not directly related to the number of CPUs in the node. Are you
thinking of busiest->group_weight?

-- 
Mel Gorman
SUSE Labs