Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <03ad3a0a1d8e84c12ad958e291040a32a49c9f0f.camel@surriel.com>
Subject: Re: [PATCH] sched, fair: Allow a small load imbalance between low
 utilisation SD_NUMA domains v3
From:   Rik van Riel <riel@surriel.com>
To:     Mel Gorman <mgorman@techsingularity.net>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, pauld@redhat.com,
        valentin.schneider@arm.com, srikar@linux.vnet.ibm.com,
        quentin.perret@arm.com, dietmar.eggemann@arm.com,
        Morten.Rasmussen@arm.com, hdanton@sina.com, parth@linux.ibm.com,
        LKML <linux-kernel@vger.kernel.org>
Date:   Mon, 06 Jan 2020 11:44:57 -0500
In-Reply-To: <20200106163303.GC3466@techsingularity.net>
References: <20200106144250.GA3466@techsingularity.net>
         <04033a63f11a9c59ebd2b099355915e4e889b772.camel@surriel.com>
         <20200106163303.GC3466@techsingularity.net>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-sPn5r1noHxTQZJxPt3V5"
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-sPn5r1noHxTQZJxPt3V5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2020-01-06 at 16:33 +0000, Mel Gorman wrote:
> On Mon, Jan 06, 2020 at 10:47:18AM -0500, Rik van Riel wrote:
> > > +			imbalance_adj =3D (100 / (env->sd->imbalance_pct
> > > - 100)) - 1;
> > > +
> > > +			/*
> > > +			 * Allow small imbalances when the busiest
> > > group has
> > > +			 * low utilisation.
> > > +			 */
> > > +			imbalance_max =3D imbalance_adj << 1;
> > > +			if (busiest->sum_nr_running < imbalance_max)
> > > +				env->imbalance -=3D min(env->imbalance,
> > > imbalance_adj);
> > > +		}
> > > +
> >=20
> > Wait, so imbalance_max is a function only of
> > env->sd->imbalance_pct, and it gets compared
> > against busiest->sum_nr_running, which is related
> > to the number of CPUs in the node?
> >=20
>=20
> It's not directly related to the number of CPUs in the node. Are you
> thinking of busiest->group_weight?

I am, because as it is right now that if condition
looks like it might never be true for imbalance_pct 115.

Presumably you put that check there for a reason, and
would like it to trigger when the amount by which a node
is busy is less than 2 * (imbalance_pct - 100).

--=20
All Rights Reversed.

--=-sPn5r1noHxTQZJxPt3V5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl4TZAkACgkQznnekoTE
3oMU3ggAqglhu6aXyxYNartxLHIT5xSm8cCf4hEGUUYU8yUG1Ti+Q5XLV3LHltMa
k9YkG32W+H2zlnatDY8FCmZ/lxoF+R/6ZcoXIlTQhY8s6mbbv92lEqQxeyorX7P2
vwzRGz/gaEfOv5/CSoJu2wkNgyZ5r2gMxMDqRKYoevxg87XzNqrcy1D2YiNMqcH6
gFYc2PKSiT4krfuLPNMANLZp63vQnD0Nu6m4m4Z4GsiuaYqbJyU1GJWVQfihYZUc
v+mhzKopJtcShkj1SNwdNvZWpyA7wbpucNEleO/vx93hxG4TARgS7a6HL34i6HS1
LqkKwTetbXPkAwFX8dUcCDGfNUwy0g==
=OwY9
-----END PGP SIGNATURE-----

--=-sPn5r1noHxTQZJxPt3V5--