Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200106181329.167322-1-hridya@google.com> <d78e4db4-5847-082c-189a-f13d7d6a6c7a@tycho.nsa.gov>
In-Reply-To: <d78e4db4-5847-082c-189a-f13d7d6a6c7a@tycho.nsa.gov>
From:   Hridya Valsaraju <hridya@google.com>
Date:   Mon, 6 Jan 2020 11:06:44 -0800
Message-ID: <CA+wgaPMHWOVYo_pVeYuvj6CrQOgy9=vQco+tnGHjPX3=CLh5wA@mail.gmail.com>
Subject: Re: [PATCH] security: selinux: allow per-file labelling for binderfs
To:     Stephen Smalley <sds@tycho.nsa.gov>
Cc:     Paul Moore <paul@paul-moore.com>,
        Eric Paris <eparis@parisplace.org>, selinux@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Android Kernel Team <kernel-team@android.com>,
        Jeff Vander Stoep <jeffv@google.com>,
        Mark Salyzyn <salyzyn@android.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 6, 2020 at 10:33 AM 'Stephen Smalley' via kernel-team
<kernel-team@android.com> wrote:
>
> On 1/6/20 1:13 PM, Hridya Valsaraju wrote:
> > This patch allows genfscon per-file labeling for binderfs.
> > This is required to have separate permissions to allow
> > access to binder, hwbinder and vndbinder devices which are
> > relocating to binderfs.
> >
> > Acked-by: Jeff Vander Stoep <jeffv@google.com>
> > Acked-by: Mark Salyzyn <salyzyn@android.com>
> > Signed-off-by: Hridya Valsaraju <hridya@google.com>
>
> Do you want binderfs to also support userspace labeling of files via
> setxattr()?  If so, you'll want to also add it to
> selinux_is_genfs_special_handling() as well.

Thank you for the quick response Stephen :) I cannot think of a
use-case for the userspace labelling of files in binderfs via
setxattr() as of now. I
will make the change if one comes up!

Thanks,
Hridya


>
> > ---
> >   security/selinux/hooks.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> > index 116b4d644f68..3f0669a708e9 100644
> > --- a/security/selinux/hooks.c
> > +++ b/security/selinux/hooks.c
> > @@ -752,6 +752,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
> >
> >       if (!strcmp(sb->s_type->name, "debugfs") ||
> >           !strcmp(sb->s_type->name, "tracefs") ||
> > +         !strcmp(sb->s_type->name, "binderfs") ||
> >           !strcmp(sb->s_type->name, "pstore"))
> >               sbsec->flags |= SE_SBGENFS;
> >
> >
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>