Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Date:   Mon, 6 Jan 2020 19:15:15 -0300
To:     "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Dennis Schridde <devurandom@gmx.net>,
        Denis Pronin <dannftk@yandex.ru>,
        Naohiro Aota <naota@elisp.net>,
        clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf clang: Fix build with Clang 9
Message-ID: <20200106221515.GE11285@kernel.org>
References: <20191228171314.946469-2-mail@maciej.szmigiero.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191228171314.946469-2-mail@maciej.szmigiero.name>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Sat, Dec 28, 2019 at 06:13:14PM +0100, Maciej S. Szmigiero escreveu:
> LLVM D59377 (included in Clang 9) refactored Clang VFS construction a bit,
> which broke perf clang build.
> Let's fix it.
> 
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> Reviewed-by: Dennis Schridde <devurandom@gmx.net>

Thanks, applied.

- Arnaldo

> ---
>  tools/perf/util/c++/clang.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/util/c++/clang.cpp b/tools/perf/util/c++/clang.cpp
> index fc361c3f8570..c8885dfa3667 100644
> --- a/tools/perf/util/c++/clang.cpp
> +++ b/tools/perf/util/c++/clang.cpp
> @@ -71,7 +71,11 @@ getModuleFromSource(llvm::opt::ArgStringList CFlags,
>  	CompilerInstance Clang;
>  	Clang.createDiagnostics();
>  
> +#if CLANG_VERSION_MAJOR < 9
>  	Clang.setVirtualFileSystem(&*VFS);
> +#else
> +	Clang.createFileManager(&*VFS);
> +#endif
>  
>  #if CLANG_VERSION_MAJOR < 4
>  	IntrusiveRefCntPtr<CompilerInvocation> CI =

-- 

- Arnaldo