Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 06 Jan 2020 19:21:40 -0800
User-Agent: K-9 Mail for Android
In-Reply-To: <CAK7LNAT2ai=-wbLmU2hqihbzVy7kKCGg=ipOK09XtSWiDYMW1Q@mail.gmail.com>
References: <20200104150238.19834-1-masahiroy@kernel.org> <20200104150238.19834-5-masahiroy@kernel.org> <xr93ftgt6ndv.fsf@gthelen.svl.corp.google.com> <CAK7LNAT2ai=-wbLmU2hqihbzVy7kKCGg=ipOK09XtSWiDYMW1Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v2 04/13] initramfs: rename gen_initramfs_list.sh to gen_initramfs.sh
To:     Masahiro Yamada <masahiroy@kernel.org>,
        Greg Thelen <gthelen@google.com>,
        Ben Hutchings <ben@decadent.org.uk>
CC:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From:   hpa@zytor.com
Message-ID: <AB861F14-0F89-4A9B-AC24-34D86DDCB935@zytor.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On January 6, 2020 2:26:22 AM PST, Masahiro Yamada <masahiroy@kernel=2Eorg>=
 wrote:
>(+CC Ben Hutchings, H=2E Peter Anvin)
>
>In my understanding, the klibc build system is standalone=2E
>So, the change in Linux kernel does not affect klibc at all=2E
>Only the depending part is UAPI headers (make headers_install)=2E
>
>So, this patch
>(https://lore=2Ekernel=2Eorg/patchwork/patch/1175336/)
>should be OK=2E
>
>Please correct me if I am wrong=2E
>
>
>On Mon, Jan 6, 2020 at 4:43 PM Greg Thelen <gthelen@google=2Ecom> wrote:
>>
>> Masahiro Yamada <masahiroy@kernel=2Eorg> wrote:
>>
>> > The comments in usr/Makefile wrongly refer to the script name
>(twice)=2E
>> >
>> > Line 37:
>> >     # The dependency list is generated by gen_initramfs=2Esh -l
>> >
>> > Line 54:
>> >     # 4) Arguments to gen_initramfs=2Esh changes
>> >
>> > There does not exist such a script=2E
>> >
>> > I was going to fix the comments, but after some consideration, I
>thought
>> > "gen_initramfs=2Esh" would be more suitable than
>"gen_initramfs_list=2Esh"
>> > because it generates an initramfs image in the common usage=2E
>> >
>> > The script generates a list that can be fed to gen_init_cpio only
>when
>> > it is directly run without -o or -l option=2E
>> >
>> > Signed-off-by: Masahiro Yamada <masahiroy@kernel=2Eorg>
>> > ---
>> >
>> > Changes in v2: None
>> >
>> >  usr/Makefile                                    | 2 +-
>> >  usr/{gen_initramfs_list=2Esh =3D> gen_initramfs=2Esh} | 0
>> >  2 files changed, 1 insertion(+), 1 deletion(-)
>> >  rename usr/{gen_initramfs_list=2Esh =3D> gen_initramfs=2Esh} (100%)
>>
>> Will this break klibc?  It might have a ref to the old name=2E
>>
>https://git=2Ekernel=2Eorg/pub/scm/libs/klibc/klibc=2Egit/tree/usr/Kbuild=
#n55
>
>I do not think so=2E
>
>As I stated above, the klibc build system is independent of
>any script in the Linux kernel=2E
>
>The klibc Makefile refers to
>scripts/gen_initramfs_list=2Esh, which does not exist=2E
>
>My path is renaming
>usr/gen_initramfs_list=2Esh to usr/gen_initramfs=2Esh
>
>
>If the renaming had been problematic for klibc,
>commit f6f57a46435d7253a52a1a07a58183678ad266a0
>("initramfs: move gen_initramfs_list=2Esh from scripts/ to usr/")
>would have already caused a problem=2E
>
>
>
>Ben, Hans,
>Is usr/Kbuild in klibc used?
>If it is not used, is it better to delete it to avoid confusion?
>
>
>Masahiro Yamada
>
>
>
>
>> > diff --git a/usr/Makefile b/usr/Makefile
>> > index 55c942da01cd=2E=2Ee44a66b8c051 100644
>> > --- a/usr/Makefile
>> > +++ b/usr/Makefile
>> > @@ -24,7 +24,7 @@ $(obj)/initramfs_data=2Eo: $(obj)/$(datafile_y)
>FORCE
>> >  # Generate the initramfs cpio archive
>> >
>> >  hostprogs-y :=3D gen_init_cpio
>> > -initramfs   :=3D $(CONFIG_SHELL)
>$(srctree)/$(src)/gen_initramfs_list=2Esh
>> > +initramfs   :=3D $(CONFIG_SHELL) $(srctree)/$(src)/gen_initramfs=2Es=
h
>> >  ramfs-input :=3D $(if $(filter-out "",$(CONFIG_INITRAMFS_SOURCE)), \
>> >                       $(shell echo $(CONFIG_INITRAMFS_SOURCE)),-d)
>> >  ramfs-args  :=3D \
>> > diff --git a/usr/gen_initramfs_list=2Esh b/usr/gen_initramfs=2Esh
>> > similarity index 100%
>> > rename from usr/gen_initramfs_list=2Esh
>> > rename to usr/gen_initramfs=2Esh

That is correct=2E

The klibc integration work was mainly fine in an actual kernel tree, which=
 pulled the klibc tree=2E

It has obviously bitrotted somewhat, but it wouldn't be all that hard to r=
esurrect it if there is ever interest=2E

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E