Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Sriram Dash" <sriram.dash@samsung.com>
To:     =?iso-8859-1?Q?'Heiko_St=FCbner'?= <heiko@sntech.de>,
        "'Florian Fainelli'" <f.fainelli@gmail.com>
Cc:     <linux-arm-kernel@lists.infradead.org>,
        "'David Miller'" <davem@davemloft.net>, <p.rajanbabu@samsung.com>,
        <pankaj.dubey@samsung.com>, <Jose.Abreu@synopsys.com>,
        <jayati.sahu@samsung.com>, <alexandre.torgue@st.com>,
        <rcsekar@samsung.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        <peppe.cavallaro@st.com>,
        <linux-stm32@st-md-mailman.stormreply.com>
In-Reply-To: <1599392.7x4dJXGyiB@diego>
Subject: RE: [PATCH] net: stmmac: platform: Fix MDIO init for platforms
 without PHY
Date:   Tue, 7 Jan 2020 11:04:20 +0530
Message-ID: <011901d5c51c$1f93be30$5ebb3a90$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-in
Thread-Index: AQHLzAO/yISlXyWkyxclgJwcl7iTGwGwvbPnApU1MP0CKNLZ9qe/HwAA
CMS-TYPE: 105P
References: <CGME20191219102407epcas5p103b26e6fb191f7135d870a3449115c89@epcas5p1.samsung.com>
        <1700835.tBzmY8zkgn@diego> <c25fbdb3-0e60-6e54-d58a-b05e8b805a58@gmail.com>
        <1599392.7x4dJXGyiB@diego>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> From: Heiko St=FCbner=20<heiko=40sntech.de>=0D=0A>=20Subject:=20Re:=20=5B=
PATCH=5D=20net:=20stmmac:=20platform:=20Fix=20MDIO=20init=20for=20platforms=
=0D=0Awithout=0D=0A>=20PHY=0D=0A>=20=0D=0A>=20Hi=20Florian,=0D=0A>=20=0D=0A=
>=20Am=20Sonntag,=205.=20Januar=202020,=2023:22:00=20CET=20schrieb=20Floria=
n=20Fainelli:=0D=0A>=20>=20On=201/5/2020=2012:43=20PM,=20Heiko=20St=FCbner=
=20wrote:=0D=0A>=20>=20>=20Am=20Samstag,=2021.=20Dezember=202019,=2006:29:1=
8=20CET=20schrieb=20David=20Miller:=0D=0A>=20>=20>>=20From:=20Padmanabhan=
=20Rajanbabu=20<p.rajanbabu=40samsung.com>=0D=0A>=20>=20>>=20Date:=20Thu,=
=2019=20Dec=202019=2015:47:01=20+0530=0D=0A>=20>=20>>=0D=0A>=20>=20>>>=20Th=
e=20current=20implementation=20of=20=22stmmac_dt_phy=22=20function=20initia=
lizes=0D=0A>=20>=20>>>=20the=20MDIO=20platform=20bus=20data,=20even=20in=20=
the=20absence=20of=20PHY.=20This=20fix=0D=0A>=20>=20>>>=20will=20skip=20MDI=
O=20initialization=20if=20there=20is=20no=20PHY=20present.=0D=0A>=20>=20>>>=
=0D=0A>=20>=20>>>=20Fixes:=207437127=20(=22net:=20stmmac:=20Convert=20to=20=
phylink=20and=20remove=20phylib=0D=0A>=20>=20>>>=20logic=22)=0D=0A>=20>=20>=
>>=20Acked-by:=20Jayati=20Sahu=20<jayati.sahu=40samsung.com>=0D=0A>=20>=20>=
>>=20Signed-off-by:=20Sriram=20Dash=20<sriram.dash=40samsung.com>=0D=0A>=20=
>=20>>>=20Signed-off-by:=20Padmanabhan=20Rajanbabu=20<p.rajanbabu=40samsung=
.com>=0D=0A>=20>=20>>=0D=0A>=20>=20>>=20Applied=20and=20queued=20up=20for=
=20-stable,=20thanks.=0D=0A>=20>=20>=0D=0A>=20>=20>=20with=20this=20patch=
=20applied=20I=20now=20run=20into=20issues=20on=20multiple=20rockchip=0D=0A=
>=20>=20>=20platforms=20using=20a=20gmac=20interface.=0D=0A>=20>=0D=0A>=20>=
=20Do=20you=20have=20a=20list=20of=20DTS=20files=20that=20are=20affected=20=
by=20any=20chance?=20For=0D=0A>=20>=20the=2032-bit=20platforms=20that=20I=
=20looked=20it,=20it=20seems=20like:=0D=0A>=20>=0D=0A=0D=0AHi=20Florian,=20=
=0D=0AWe=20have=20listed=20down=20the=20platforms=20which=20will=20break=20=
for=20as=20they=20don=92t=20have=0D=0Athe=20mdio=20/=20snps,dwmac-mdio=20no=
de.=0D=0AArm32=20spear*=20,=20Arm32=20ox820*,=20arm32=20rv1108,=20arc=20abi=
lis*=20,=20arc=20axs10x*,=20arc=0D=0Avdk_axs10x*,=20mips=20pistachio,=20arm=
64=20rockchip/px30*=20There=20might=20be=20more=0D=0Aplatforms.=0D=0A=0D=0A=
>=20>=20arch/arm/boot/dts/rk3228-evb.dts=20is=20OK=20because=20it=20has=20a=
=20MDIO=20bus=20node=0D=0A>=20>=20arch/arm/boot/dts/rk3229-xms6.dts=20is=20=
also=20OK=0D=0A>=20>=0D=0A>=20>=20arch/arm/boot/dts/rk3229-evb.dts=20is=20p=
robably=20broken,=20there=20is=20no=0D=0A>=20>=20phy-handle=20property=20or=
=20MDIO=20bus=20node,=20so=20it=20must=20be=20relying=20on=0D=0A>=20>=20aut=
o-scanning=20of=20the=20bus=20somehow=20that=20this=20patch=20broke.=0D=0A>=
=20>=0D=0A>=20>=20And=20likewise=20for=20most=2064-bit=20platforms=20except=
=20a1=20and=20nanopi4.=0D=0A>=20=0D=0A>=20I=20primarily=20noticed=20that=20=
on=20the=20px30-evb.dts=20and=20the=20internal=20board=20I'm=0D=0Aworking=
=0D=0A>=20on=20right=20now.=20Both=20don't=20have=20that=20mdio=20bus=20nod=
e=20right=20now.=0D=0A>=20=0D=0A>=20=0D=0A>=20>=20>=20When=20probing=20the=
=20driver=20and=20trying=20to=20establish=20a=20connection=20for=20a=0D=0A>=
=20>=20>=20nfsroot=20it=20always=20runs=20into=20a=20null=20pointer=20in=20=
mdiobus_get_phy():=0D=0A>=20>=20>=0D=0A>=20>=20>=20=5B=20=20=2026.878839=5D=
=20rk_gmac-dwmac=20ff360000.ethernet:=20IRQ=20eth_wake_irq=20not=0D=0A>=20f=
ound=0D=0A>=20>=20>=20=5B=20=20=2026.886322=5D=20rk_gmac-dwmac=20ff360000.e=
thernet:=20IRQ=20eth_lpi=20not=20found=0D=0A>=20>=20>=20=5B=20=20=2026.8945=
05=5D=20rk_gmac-dwmac=20ff360000.ethernet:=20PTP=20uses=20main=20clock=0D=
=0A>=20>=20>=20=5B=20=20=2026.908209=5D=20rk_gmac-dwmac=20ff360000.ethernet=
:=20clock=20input=20or=20output?=0D=0A>=20(output).=0D=0A=0D=0A...=20snip=
=20...=0D=0A=0D=0A>=20>=20>=0D=0A>=20>=20>=0D=0A>=20>=20>=20This=20is=20tor=
valds=20git=20head=20and=20it=20was=20still=20working=20at=20-rc1=20and=20a=
ll=0D=0A>=20>=20>=20kernels=20before=20that.=20When=20I=20just=20revert=20t=
his=20commit,=20things=20also=0D=0A>=20>=20>=20start=20working=20again,=20s=
o=20I=20guess=20something=20must=20be=20wrong=20here?=0D=0A>=20>=0D=0A>=20>=
=20Yes,=20this=20was=20also=20identified=20to=20be=20problematic=20by=20the=
=20kernelci=20boot=0D=0A>=20>=20farms=20on=20another=20platform,=20see=20=
=5B1=5D.=0D=0A>=20>=0D=0A>=20>=20=5B1=5D:=0D=0A>=20>=20https://lore.kernel.=
org/linux-arm-kernel/5e0314da.1c69fb81.a7d63.29c1=40=0D=0A>=20>=20mx.google=
.com/=0D=0A>=20>=0D=0A>=20>=20Do=20you=20mind=20trying=20this=20patch=20and=
=20letting=20me=20know=20if=20it=20works=20for=20you.=0D=0A>=20>=20Sriram,=
=20please=20also=20try=20it=20on=20your=20platforms=20and=20let=20me=20know=
=20if=20solves=0D=0A>=20>=20the=20problem=20you=20were=20after.=20Thanks=0D=
=0A>=20=0D=0A>=20Works=20on=20both=20boards=20I=20had=20that=20were=20affec=
ted,=20so=0D=0A>=20Tested-by:=20Heiko=20Stuebner=20<heiko=40sntech.de>=0D=
=0A=0D=0ANacked-by=20:=20Sriram=20Dash=20<Sriram.dash=40samsung.com>=0D=0A=
=0D=0A>=20=0D=0A>=20=0D=0A>=20Thanks=0D=0A>=20Heiko=0D=0A>=20=0D=0A>=20>=0D=
=0A>=20>=20diff=20--git=20a/drivers/net/ethernet/stmicro/stmmac/stmmac_plat=
form.c=0D=0A>=20>=20b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c=
=0D=0A>=20>=20index=20cc8d7e7bf9ac..e192b8e0809e=20100644=0D=0A>=20>=20---=
=20a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c=0D=0A>=20>=20+++=
=20b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c=0D=0A>=20>=20=40=
=40=20-320,7=20+320,7=20=40=40=20static=20int=20stmmac_mtl_setup(struct=20p=
latform_device=0D=0A>=20>=20*pdev,=20=20static=20int=20stmmac_dt_phy(struct=
=20plat_stmmacenet_data=20*plat,=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20struct=20device_node=20*np,=
=20struct=20device=20*dev)=0D=0A>=20>=20=7B=0D=0A>=20>=20-=20=20=20=20=20=
=20=20bool=20mdio=20=3D=20false;=0D=0A>=20>=20+=20=20=20=20=20=20=20bool=20=
mdio=20=3D=20true;=0D=0A>=20>=20=20=20=20=20=20=20=20=20static=20const=20st=
ruct=20of_device_id=20need_mdio_ids=5B=5D=20=3D=20=7B=0D=0A>=20>=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=7B=20.compatible=20=3D=20=22snps=
,dwc-qos-ethernet-4.10=22=20=7D,=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=7B=7D,=0D=0A>=20>=20=40=40=20-341,8=20+341,9=20=40=40=
=20static=20int=20stmmac_dt_phy(struct=0D=0A>=20>=20plat_stmmacenet_data=20=
*plat,=0D=0A>=20>=20=20=20=20=20=20=20=20=20=7D=0D=0A>=20>=0D=0A>=20>=20=20=
=20=20=20=20=20=20=20if=20(plat->mdio_node)=20=7B=0D=0A=0D=0AFor=20the=20pl=
atforms=20which=20neither=20have=20mdio=20nor=20snps,dwmac-mdio=20property=
=20in=0D=0Adt,=20they=20will=20not=20enter=20the=20block.=0D=0Aplat->mdio_n=
ode=20will=20always=20be=20false=20for=20them.=20Which,=20essentially,=20pr=
eserves=0D=0Athe=20mdio=20variable=20Boolean=20value=20defined=20at=20the=
=20start=20of=20the=20function.=0D=0A=0D=0A>=20>=20-=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20dev_dbg(dev,=20=22Found=20MDIO=20subnode=5Cn=22);=
=0D=0A>=20>=20-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20mdio=20=3D=20tr=
ue;=0D=0A>=20>=20+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20mdio=20=3D=
=20of_device_is_available(plat->mdio_node);=0D=0A>=20>=20+=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20dev_dbg(dev,=20=22Found=20MDIO=20subnode,=20s=
tatus:=20%sabled=5Cn=22,=0D=0A>=20>=20+=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20mdio=20?=20=22en=22=20:=20=22dis=22);=0D=
=0A>=20>=20=20=20=20=20=20=20=20=20=7D=0D=0A>=20>=0D=0A>=20>=20=20=20=20=20=
=20=20=20=20if=20(mdio)=20=7B=0D=0A>=20>=0D=0A>=20=0D=0A>=20=0D=0A>=20=0D=
=0A=0D=0AThere=20is=20a=20proposal=20for=20this=20problem=20solution.=20You=
=20can=20refer=20it=20at=20:=0D=0Ahttps://lkml.org/lkml/2020/1/7/14=0D=0A=
=0D=0A=0D=0A