Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200106191003.21584-1-tiny.windzz@gmail.com> <20200107084551.GB31906@pi3>
In-Reply-To: <20200107084551.GB31906@pi3>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Tue, 7 Jan 2020 09:49:10 +0100
Message-ID: <CAJKOXPdx3O5Vfv20UsD3qh5UC7TczrY9pBPObGcqamFt=9Pw5A@mail.gmail.com>
Subject: Re: [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node
To:     Yangtao Li <tiny.windzz@gmail.com>
Cc:     robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 7 Jan 2020 at 09:45, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote:
> > The patch adds fimd node for tiny4412 device.
>
> Hi,
>
> Thanks for the patch.
>
> Do not use "This patch ..." sentences but simple, imperative mode:
> https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
>
> Here you do not add FIMD node, because the FIMD is already there
> (defined in exynos4.dtsi).  You however enable it.
>
> Enabling it without panel does not really make sense - does it work?
> I guess not, so this should be squashed with second patch.

... unless it really works without panel, then it makes sense to keep
it separate. However in such case, the #cells properties belong to
second patch.

Best regards,
Krzysztof