Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp33800ybl; Tue, 7 Jan 2020 01:33:51 -0800 (PST) X-Google-Smtp-Source: APXvYqxjT6CbJB8w+UZjGMaYVRGf17dp9tp8CRM8ru2J7a0I5f4ylFAGH6zWm2DoEqTHcR/AfTkz X-Received: by 2002:a05:6830:1c81:: with SMTP id v1mr123729913otf.83.1578389631761; Tue, 07 Jan 2020 01:33:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578389631; cv=none; d=google.com; s=arc-20160816; b=k+4yHy2me60O93qhOMJo32tMna7o9s8QK3u4vRq/nDYF8/jFy2iYyPsFJB8vCdhM/a pe5a4OoHAI58lECRSQP9I8eWMU1p3FP0PU4XpvErT3wrWg105/sqmUbedlFaMTn9TVRb Jx6yRSbVWXrTDqjGtO82w7q1wevYkaUvoY8WrPavqOBG1ilQ/5PKjfIMIaup6N2ZW2un ZF4YZ+dP3oLS1CZjL62Oh5IgwjgnOfHCg5KwTfFlc2xzCzmm2glw20Wx2/HYcBU1fFQH 9CYrTtLVUYGOfblsajVEwob2+tAoT8+fqLr2u2m9nxe2Gv9xoMAAhGdSX2J+Ib9xK3m9 Y9XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=FHSr1IYP6sHrnY75lBxGflLY4NIZIBc6Izm2kKVNa1E=; b=TT+NBzHN4diRdKr/tWo9lDtBspdFSZRuCVs8BeY86x5Zyia4WFzf6/qzgagiEIMX0/ sjHlfiUwkxpXUJWXoUvA2uTM2igtHbGJyVkwNppE4MfLsOpExsPCJ700bWEyNy5+u3AM /q+sZWnLPBGJzyFGQIodCe/7GoG5A1k7sHF1nCOwOcIu0tQjb6QNo/iDco8Lsnpj0EWv HXvCIQ6B+HE7/73PSxxwNz6RwtZxkHZI8LBsS3uPJyll/FyhOrU27VXHl8NlHq7OlKYX +NunuWgu8x0PBhH6biJxdSz/Uy1vG649+8gyI1gIYkZcZ1Y3pZeyVLC9542yBGADlBmB d5dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="s1NMDq9/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d8si526342oti.306.2020.01.07.01.33.38; Tue, 07 Jan 2020 01:33:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="s1NMDq9/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727671AbgAGJb6 (ORCPT + 99 others); Tue, 7 Jan 2020 04:31:58 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:34656 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbgAGJb6 (ORCPT ); Tue, 7 Jan 2020 04:31:58 -0500 Received: by mail-qk1-f195.google.com with SMTP id j9so42466927qkk.1 for ; Tue, 07 Jan 2020 01:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=FHSr1IYP6sHrnY75lBxGflLY4NIZIBc6Izm2kKVNa1E=; b=s1NMDq9/sBrmA5XoPocAi78NArZo9kNNswJunowCk2YHw7EZeh5mcuiJsdOUmT9dQ9 zdxvvuLWbBaXFnUjhtCJaoowFYzNm24hnlXcLDPpFk+bp7M8K7aVIvNyMBmZcbCd5Jwa Qca0XIrWeeSWpoZbTEIkBbrx+36kVsDEBPwz066sTFsU7DAzAxdOOVsucbBtCvUOPYn4 8yGu6Jaz+pdyxk3zBicmw8bKsQ1c+bYEkuyCDf4v9wyCLliimHSBuFvBvVHhCytSU0yu Rw+ggJEMZDX7Li5zFP5eDDI70qlIk+2MhudI1L2CE968YPlvrEZanauHkhEpTHRpn5XS qlPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FHSr1IYP6sHrnY75lBxGflLY4NIZIBc6Izm2kKVNa1E=; b=ZE8QWRc7bpJMr9pZdDnMCCOfwccbiTT6HxVW39Gzpe5FnMoMcJJ0kHBAVab3Vs2e4j ye7tw/3Emp6fkqrNvJcUysWm08NXZV9Q8Uv3NGWkHHxBFlmGdqxxPNmIAMiUn7TL9MoV 0MnHDTWfQ4KJtRpb3YHTpRh81X5KXsuds/f3JoF1xEZdetL0ZAZah6DHE1qHAwOq4X/0 i2NGWXFXWLJve2VvWkTmJ18eCqDt/UTiTSAWzfaTQrKBiZAdLVatVVdYfEAYsc5Np8Zf fMmeUem8BWcer4X2KEtEzCds5S3FrUeDTXVIBTK/hmU0XV8FEM7TKNXdJ6REYwLqIs8Z Hq9w== X-Gm-Message-State: APjAAAWqb5S+3TTjPg6UW8gPpz86GYfQ8eVQtFNwecXn5abpSyH+tkC/ aq3ssv3jAz9NVOSWLysEIzZq9L13DI3eLZrA0n0pfw== X-Received: by 2002:a37:6fc4:: with SMTP id k187mr74675027qkc.21.1578389517217; Tue, 07 Jan 2020 01:31:57 -0800 (PST) MIME-Version: 1.0 References: <20191215183047.9414-1-digetx@gmail.com> In-Reply-To: From: Bartosz Golaszewski Date: Tue, 7 Jan 2020 10:31:46 +0100 Message-ID: Subject: Re: [PATCH v1 0/3] Tegra GPIO: Minor code clean up To: Linus Walleij Cc: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , "open list:GPIO SUBSYSTEM" , linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org wt., 7 sty 2020 o 10:29 Linus Walleij napisa=C5= =82(a): > > On Tue, Jan 7, 2020 at 9:25 AM Bartosz Golaszewski > wrote: > > > pon., 6 sty 2020 o 23:59 Linus Walleij napis= a=C5=82(a): > > > On Sun, Dec 15, 2019 at 7:31 PM Dmitry Osipenko wr= ote: > > > > > > > I was investigating why CPU hangs during of GPIO driver suspend and= in > > > > the end it turned out that it is a Broadcom WiFi driver problem bec= ause > > > > it keeps OOB wake-interrupt enabled while WLAN interface is DOWN an= d this > > > > may cause a bit weird CPU hang on writing to INT_ENB register durin= g of > > > > GPIO driver suspend. Meanwhile I also noticed that a few things cou= ld be > > > > improved in the driver, that's what this small series addresses. > > > > > > > > Dmitry Osipenko (3): > > > > gpio: tegra: Use generic readl_relaxed/writel_relaxed accessors > > > > gpio: tegra: Properly handle irq_set_irq_wake() error > > > > gpio: tegra: Use NOIRQ phase for suspend/resume > > > > > > All three patches applied with Thierry's review/test tag. > > > > > > Yours, > > > Linus Walleij > > > > Ugh, I now noticed I responded to Thierry only after applying this to m= y tree. > > > > Anyway, it shouldn't be a problem. I'll take more care next time. > > OK shall I drop the patches from my tree then? No big deal. > If you're fine with this, sure! Thanks a lot, Bart