Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Jan 2020 10:32:14 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Wei Li <liwei391@huawei.com>, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de,
        huawei.libin@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/debug: Reset watchdog on all CPUs while processing
 sysrq-t
Message-ID: <20200107093214.GV2844@hirez.programming.kicks-ass.net>
References: <20191226085224.48942-1-liwei391@huawei.com>
 <20200102144514.646df101@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200102144514.646df101@gandalf.local.home>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jan 02, 2020 at 02:45:14PM -0500, Steven Rostedt wrote:
> On Thu, 26 Dec 2019 16:52:24 +0800
> Wei Li <liwei391@huawei.com> wrote:
> 
> > Lengthy output of sysrq-t may take a lot of time on slow serial console
> > with lots of processes and CPUs.
> > 
> > So we need to reset NMI-watchdog to avoid spurious lockup messages, and
> > we also reset softlockup watchdogs on all other CPUs since another CPU
> > might be blocked waiting for us to process an IPI or stop_machine.
> 
> Have you had this triggered?
> 
> > 
> > Add to sysrq_sched_debug_show() as what we did in show_state_filter().
> > 
> > Signed-off-by: Wei Li <liwei391@huawei.com>
> > ---
> >  kernel/sched/debug.c | 11 +++++++++--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> > index f7e4579e746c..879d3ccf3806 100644
> > --- a/kernel/sched/debug.c
> > +++ b/kernel/sched/debug.c
> > @@ -751,9 +751,16 @@ void sysrq_sched_debug_show(void)
> >  	int cpu;
> >  
> >  	sched_debug_header(NULL);
> > -	for_each_online_cpu(cpu)
> > +	for_each_online_cpu(cpu) {
> > +		/*
> > +		 * Need to reset softlockup watchdogs on all CPUs, because
> > +		 * another CPU might be blocked waiting for us to process
> > +		 * an IPI or stop_machine.
> > +		 */
> > +		touch_nmi_watchdog();
> > +		touch_all_softlockup_watchdogs();
> 
> This doesn't seem to hurt to add, thus.
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Thanks!